If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

getVerticalSpacing() is only available on SDK >= 16

RESOLVED FIXED in Firefox 36

Status

()

Firefox for Android
General
P1
normal
RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: lucasr, Assigned: lucasr)

Tracking

unspecified
Firefox 37
All
Android
Points:
---

Firefox Tracking Flags

(firefox36 fixed, firefox37 fixed, fennec36+)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
And TabsGridLayout is using it. We should replace this call with something that works on SDK >= 11.
This sounds like a pre-16 crash in the making. Tracking?
tracking-fennec: --- → ?
(Assignee)

Comment 2

3 years ago
(In reply to Richard Newman [:rnewman] from comment #1)
> This sounds like a pre-16 crash in the making. Tracking?
Priority: -- → P1
(Assignee)

Updated

3 years ago
Duplicate of this bug: 1108418
Let's get this fixed
tracking-fennec: ? → 36+
(Assignee)

Comment 5

3 years ago
Created attachment 8533796 [details] [diff] [review]
Replace getVerticalSpacing() call with a dimen resource (r=mfinkle)
(Assignee)

Updated

3 years ago
Attachment #8533796 - Flags: review?(mark.finkle)
(Assignee)

Updated

3 years ago
Assignee: mhaigh → lucasr.at.mozilla
Attachment #8533796 - Flags: review?(mark.finkle) → review+

Updated

3 years ago
tracking-fennec: 36+ → ?
Tablet UI is riding trains on Fx36. Let's make sure this fix is uplifted if needed.
tracking-fennec: ? → 36+
(Assignee)

Comment 7

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/e2f022366721
(Assignee)

Comment 8

3 years ago
Comment on attachment 8533796 [details] [diff] [review]
Replace getVerticalSpacing() call with a dimen resource (r=mfinkle)

Approval Request Comment
[Feature/regressing bug #]: New tablet UI (bug 1014156)
[User impact if declined]: Fennec crashes on pre-16 Android tablets.
[Describe test coverage new/current, TBPL]: Local testing only, let's bake in Nightly for a bit and then uplift.
[Risks and why]: Low, simply replace a method call with a resource value.
[String/UUID change made/needed]: n/a
Attachment #8533796 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/e2f022366721
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
status-firefox36: --- → affected
status-firefox37: --- → verified disabled
status-firefox37: verified disabled → fixed
Attachment #8533796 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8533796 [details] [diff] [review]
Replace getVerticalSpacing() call with a dimen resource (r=mfinkle)

> let's bake in Nightly for a bit and then uplift.
revert my approval
Attachment #8533796 - Flags: approval-mozilla-aurora+ → approval-mozilla-aurora?
Attachment #8533796 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/0af89e9ffe03
status-firefox36: affected → fixed
You need to log in before you can comment on or make changes to this bug.