Closed Bug 1106118 Opened 9 years ago Closed 9 years ago

getVerticalSpacing() is only available on SDK >= 16

Categories

(Firefox for Android Graveyard :: General, defect, P1)

All
Android
defect

Tracking

(firefox36 fixed, firefox37 fixed, fennec36+)

RESOLVED FIXED
Firefox 37
Tracking Status
firefox36 --- fixed
firefox37 --- fixed
fennec 36+ ---

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

Attachments

(1 file)

And TabsGridLayout is using it. We should replace this call with something that works on SDK >= 11.
This sounds like a pre-16 crash in the making. Tracking?
tracking-fennec: --- → ?
(In reply to Richard Newman [:rnewman] from comment #1)
> This sounds like a pre-16 crash in the making. Tracking?
Priority: -- → P1
Let's get this fixed
tracking-fennec: ? → 36+
Attachment #8533796 - Flags: review?(mark.finkle)
Assignee: mhaigh → lucasr.at.mozilla
Attachment #8533796 - Flags: review?(mark.finkle) → review+
tracking-fennec: 36+ → ?
Tablet UI is riding trains on Fx36. Let's make sure this fix is uplifted if needed.
tracking-fennec: ? → 36+
Comment on attachment 8533796 [details] [diff] [review]
Replace getVerticalSpacing() call with a dimen resource (r=mfinkle)

Approval Request Comment
[Feature/regressing bug #]: New tablet UI (bug 1014156)
[User impact if declined]: Fennec crashes on pre-16 Android tablets.
[Describe test coverage new/current, TBPL]: Local testing only, let's bake in Nightly for a bit and then uplift.
[Risks and why]: Low, simply replace a method call with a resource value.
[String/UUID change made/needed]: n/a
Attachment #8533796 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/e2f022366721
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Attachment #8533796 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8533796 [details] [diff] [review]
Replace getVerticalSpacing() call with a dimen resource (r=mfinkle)

> let's bake in Nightly for a bit and then uplift.
revert my approval
Attachment #8533796 - Flags: approval-mozilla-aurora+ → approval-mozilla-aurora?
Attachment #8533796 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.