1106124 - Profiler tab time section background color is overridden on hover

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Tim Nguyen :ntim]

I suspect these are regressions of bug 1102369.

Debugger :
Text color of placeholders for empty tab panels are black in dark theme

Performance :
In the "top" tabs, when hovering the selected tab, the tab loses it's blue background

Comment 1

[Tim Nguyen :ntim]

Also, the search input background is too light in dark theme. var(--theme-body-background) would be a perfect fit here.

Comment 2

[Brian Grinstead [:bgrins]]

(In reply to Tim Nguyen [:ntim] from comment #1)
> Also, the search input background is too light in dark theme.
> var(--theme-body-background) would be a perfect fit here.

We should be clear which of these issues are regressions of Bug 1102369, and should be uplifted.  In this case, was the search input background changed in 1102369 or is this just a suggested theme improvement?

Comment 3

[Tim Nguyen :ntim]

(In reply to Brian Grinstead [:bgrins] from comment #2)
> (In reply to Tim Nguyen [:ntim] from comment #1)
> > Also, the search input background is too light in dark theme.
> > var(--theme-body-background) would be a perfect fit here.
> 
> We should be clear which of these issues are regressions of Bug 1102369, and
> should be uplifted.  In this case, was the search input background changed
> in 1102369 or is this just a suggested theme improvement?

This is a regression of bug 1102369. You changed the search input background to a lighter one. You can just compare the search box background in the devtools and in the dev-edition UI, the 2 backgrounds previously matched.

Comment 4

[Tim Nguyen :ntim]

The border-color of the search inputs also changed btw (in dark theme).

Comment 5

[Tim Nguyen :ntim]

According to the patch, you only changed the border color of the inputs, which gave me the illusion that the background was changed as well.

Comment 6

[Brian Grinstead [:bgrins]]

(In reply to Tim Nguyen [:ntim] from comment #0)
> I suspect these are regressions of bug 1102369.
> 
> Debugger :
> Text color of placeholders for empty tab panels are black in dark theme
> 

I can't figure out exactly what this means - can you post a screenshot or explain further?

> Performance :
> In the "top" tabs, when hovering the selected tab, the tab loses it's blue
> background

Good catch, got a fix for this

Comment 7

[Tim Nguyen :ntim]

Attachment: debugger-placeholder-screenshot.png

Happens with all debugger panes. You can go to about:blank to test the issue.

Comment 8

[Brian Grinstead [:bgrins]]

Focusing this on the profiler issue, will file a new one for the debugger pane issue

Comment 9

[Brian Grinstead [:bgrins]]

Attachment: profiler-tab-hover-background.patch

Comment 10

[Brian Grinstead [:bgrins]]

(In reply to Brian Grinstead [:bgrins] from comment #8)
> Focusing this on the profiler issue, will file a new one for the debugger
> pane issue

Filed Bug 1114749

Comment 11

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/integration/fx-team/rev/e5f550fa112c

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e5f550fa112c