Closed
Bug 1106181
Opened 9 years ago
Closed 9 years ago
Intermittent browser_net_details-no-duplicated-content.js | Test timed out - expected PASS
Categories
(DevTools :: Netmonitor, defect)
Tracking
(firefox35 unaffected, firefox36 fixed, firefox37 fixed, firefox-esr31 wontfix)
RESOLVED
FIXED
Firefox 37
Tracking | Status | |
---|---|---|
firefox35 | --- | unaffected |
firefox36 | --- | fixed |
firefox37 | --- | fixed |
firefox-esr31 | --- | wontfix |
People
(Reporter: philor, Assigned: sjakthol)
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
3.35 KB,
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 2•9 years ago
|
||
Here's a patch that should fix this timeout. It improves the handling of certain edge cases caused by lazy updates used in the test. The timeout seems to occur if the updates are flushed right after the last piece of information arrives from the server. This triggers sidebar update that might complete before waitForNetworkEvents resolves in the test. As the test only starts to wait for TAB_UPDATED after waitForNetworkEvents finishes, it's waiting for an event that has already been emitted causing the test to timeout. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e2e9797389c
Attachment #8543516 -
Flags: review?(vporof)
Comment 3•9 years ago
|
||
Comment on attachment 8543516 [details] [diff] [review] netmonitor-details-duplicated-content-timeout.patch Review of attachment 8543516 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8543516 -
Flags: review?(vporof) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/7b4b861a642e
Assignee: nobody → sjakthol
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7b4b861a642e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Comment 6•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/5e460d017467
status-firefox35:
--- → unaffected
status-firefox36:
--- → fixed
status-firefox37:
--- → fixed
status-firefox-esr31:
--- → wontfix
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•