Closed Bug 1106238 Opened 5 years ago Closed 5 years ago

about:home search icon has a solid background, should be transparent

Categories

(Firefox :: General, defect)

defect
Not set
Points:
2

Tracking

()

VERIFIED FIXED
Firefox 37
Iteration:
37.1
Tracking Status
firefox34 --- wontfix
firefox35 --- verified
firefox36 --- verified
firefox37 --- verified

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #8530501 - Flags: review?(felipc)
Flags: qe-verify+
Flags: firefox-backlog+
Iteration: --- → 37.1
Points: --- → 2
Comment on attachment 8530501 [details] [diff] [review]
patch

Review of attachment 8530501 [details] [diff] [review]:
-----------------------------------------------------------------

should the same change be made to newTab.css?
Attachment #8530501 - Flags: review?(felipc) → review+
newTab.css isn't affected because it uses a div instead of a button, although that might have its own set of problems like no accessibility.
https://hg.mozilla.org/mozilla-central/rev/2ddba2cc5cff
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Comment on attachment 8530501 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1101122
[User impact if declined]: about:home search icon has a solid background, should be transparent
[Describe test coverage new/current, TBPL]: none
[Risks and why]: small isolated CSS fix, very low risk
[String/UUID change made/needed]: none
Attachment #8530501 - Flags: approval-mozilla-beta?
Attachment #8530501 - Flags: approval-mozilla-aurora?
Attachment #8530501 - Flags: approval-mozilla-beta?
Attachment #8530501 - Flags: approval-mozilla-beta+
Attachment #8530501 - Flags: approval-mozilla-aurora?
Attachment #8530501 - Flags: approval-mozilla-aurora+
QA Contact: petruta.rasa
Verified as fixed using Firefox 35 beta 3, latest Dev Edition 36.0a2 and latest Nightly 37.0a1 2014-12-12 under Win 7 64-bit, Ubuntu 14.04 32-bit and Mac OSX 10.9.5.
You need to log in before you can comment on or make changes to this bug.