1106307 - Regression: 'FennecNightly' object has no attribute '_logger'

Status: RESOLVED DUPLICATE of bug 1106088

(Testing :: mozregression, defect)

Description

[Aaron Train [:aaronmt]]

$ mozregression -n=fennec --bad=2014-11-28 --good=2014-11-21
WARNING: bisecting nightly fennec builds will clobber your existing nightly profile. Continue? (y or n)y
 0:01.66 LOG: MainThread Bisector INFO Running nightly for 2014-11-24
Traceback (most recent call last):
  File "/Users/AaronMT/Documents/Projects/mozregression/bin/mozregression", line 8, in <module>
    load_entry_point('mozregression==0.28', 'console_scripts', 'mozregression')()
  File "/Users/AaronMT/Documents/Projects/mozregression/mozregression/regression.py", line 452, in cli
    app()
  File "/Users/AaronMT/Documents/Projects/mozregression/mozregression/regression.py", line 450, in <lambda>
    get_date(options.bad_date))
  File "/Users/AaronMT/Documents/Projects/mozregression/mozregression/regression.py", line 232, in bisect_nightlies
    if self.nightly_runner.start(mid_date):
  File "/Users/AaronMT/Documents/Projects/mozregression/mozregression/runnightly.py", line 331, in start
    if not self.install(date):
  File "/Users/AaronMT/Documents/Projects/mozregression/mozregression/runnightly.py", line 324, in install
    if not self.app.download(date=date):
  File "/Users/AaronMT/Documents/Projects/mozregression/mozregression/runnightly.py", line 119, in download
    self._logger.info("Downloading build from: %s" % url)
AttributeError: 'FennecNightly' object has no attribute '_logger'

Comment 1

[Aaron Train [:aaronmt]]

$ mozregression --v
0.28

Comment 2

[Aaron Train [:aaronmt]]

Julien, do you know what's going on here?

Comment 3

[Julien Pagès (:parkouss)]

Hi Aaron,

Yes, unfortunately... We introduced a regression with the new logging feature for fennec. I already catched it here: bug 1106088 comment 3, and patch is waiting. Thanks for reporting it, anyway, and sorry for the inconvenience. :)

William, are you OK to land the pull request in bug 1106088 ? I have changed the inbound_mixin function. Not really good, but I think it is still better than what we had. Another solution is to only fix this particular regression for now.

In any case, I think you will have to bump a new version.

Comment 4

[Julien Pagès (:parkouss)]

@Aaron

Sorry it's in bug 1106088 comment 2, not 3.

Comment 5

[Aaron Train [:aaronmt]]

No worries, let's just dupe.

Comment 6

[William Lachance (:wlach)]

Merged in the interim patch in bug 1106088 and did a new release.