1106323 - mozjs17.0.0/mfbt/double-conversion/utils.h does not #define __POWERPC__

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Peter Dyballa]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/534.59.10 (KHTML, like Gecko) Version/5.1.9 Safari/534.59.10

Steps to reproduce:

I tried to compile mozjs17 on PPC Mac OS X 10.4.11 (Tiger) and Mac OS X 10.5.8 (Leopard)


Actual results:

959	:info:build bignum-dtoa.cc
960	:info:build /usr/bin/g++-4.2 -o bignum-dtoa.o -c  -fvisibility=hidden -DIMPL_MFBT -DEXPORT_JS_API -DNO_NSPR_10_SUPPORT -DUSE_ZLIB -I./../../mfbt/double-conversion -I. -I. -I./dist/include  -I/opt/local/include/nspr      -I. -I./assembler -I./yarr  -fPIC -I/opt/local/include -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wempty-body -Wno-ctor-dtor-privacy -Wno-overlength-strings -Wno-invalid-offsetof -Wno-variadic-macros -Wcast-align -Os -arch ppc -fno-common -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -pthread -pipe  -DNDEBUG -DTRIMMED -g -O3 -fno-stack-protector -fomit-frame-pointer -DUSE_SYSTEM_MALLOC=1 -DENABLE_ASSEMBLER=1  -I/opt/local/include -DMOZILLA_CLIENT -include ./js-confdefs.h -MD -MF .deps/bignum-dtoa.o.pp /Volumes/Data/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_lang_mozjs17/mozjs17/work/mozjs17.0.0/mfbt/double-conversion/bignum-dtoa.cc
961	:info:build In file included from /Volumes/Data/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_lang_mozjs17/mozjs17/work/mozjs17.0.0/mfbt/double-conversion/bignum-dtoa.h:31,
962	:info:build                  from /Volumes/Data/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_lang_mozjs17/mozjs17/work/mozjs17.0.0/mfbt/double-conversion/bignum-dtoa.cc:30:
963	:info:build /Volumes/Data/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_lang_mozjs17/mozjs17/work/mozjs17.0.0/mfbt/double-conversion/utils.h:71:2: error: #error Target architecture was not detected as supported by Double-Conversion.
964	:info:build make[1]: *** [bignum-dtoa.o] Error 1


Expected results:

Successful compilation.

The compiler used is GCC 4.2.1. It does not define __powerpc__ but __POWERPC__. This is defined in mozjs17.0.0/js/src/assembler/wtf/Platform.h but not mozjs17.0.0/mfbt/double-conversion/utils.h.

Comment 1

[Peter Dyballa]

Attachment: fix-utils.h.diff

Comment 2

[Tom S. (please needinfo tschuster)]

Thanks for your patch, however mozjs17 is not supported anymore. However we have a release candidate for Firefox 31 that you might be interested in: https://groups.google.com/d/msg/mozilla.dev.tech.js-engine/lrVCmUuXkDk/TQtz8jJ54mMJ