1106342 - mozharness mach builds can't accecpt unicode chars in src commit messages

Status: RESOLVED DUPLICATE of bug 1146035

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Jordan Lund (:jlund)]

Attachment: 141129_mh_mach_on_trunk-fix-unicode-in-src-commit.patch

https://tbpl.mozilla.org/php/getParsedLog.php?id=53816507&full=1&branch=mozilla-inbound

I think attached patch should fix the issue. I was going to try encoding correctly at the message assignment, but it looks like the issue is actually when we set that as a buildbot property and persist to file.

I think this patch is better as it improves the versatility of write_to_file and could protect us from many different entry points to it.


I'd try this on cypress before putting to prod.

Comment 1

[Chris AtLee [:catlee]]

Comment on attachment 8530579 [details] [diff] [review]
141129_mh_mach_on_trunk-fix-unicode-in-src-commit.patch

Review of attachment 8530579 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is very likely to cause fallout now, or in the future. We can't always assume we're going to be dealing with UTF-8 encoded data. Perhaps add an encoding parameter to this method, or explicitly encode the property before we write it out.