Add Mozilla Location service profile to external account

VERIFIED FIXED

Status

VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: Swarnava, Assigned: Swarnava)

Tracking

2014-12.6

Details

(Whiteboard: [kb=1603351] )

(Assignee)

Description

4 years ago
Mozilla Location service is another great way to contribute to Mozilla project. we should allow contributor to add their nickname on their mozillians profile!
(Assignee)

Comment 1

4 years ago
https://github.com/mozilla/mozillians/pull/1129
Assignee: nobody → swarnavasengupta
Whiteboard: [kb=1603351]

Comment 2

4 years ago
Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/bbeb34ce18acc64b7e2eaa5501daeabe4e32f3b0
[fix bug 1106359] Add Mozilla Location Service to external accounts.

https://github.com/mozilla/mozillians/commit/6ce1c15347072270a591dfde1d8baa9c0a68b0ad
Merge pull request #1134 from johngian/1106359

[fix bug 1106359] Add Mozilla Location Service to external accounts.

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
Version: other → next
I believe this is ready to verify, but I wanted to be sure about a few things:

For testing purposes, I used https://location.services.mozilla.com/leaders#joesph, which I found in location.services.mozilla.com

1. Positive test (expected result): Since the validator is 'validate_username_not_url', in the External Accounts field (using Mozilla Location Services), I put in URL https://location.services.mozilla.com/leaders (no #joesph at the end) and I got a validation error when saving the profile, which is good. So that works fine. 

2. I am pretty sure this is fine, but I just want to be sure: 
If I put in something like https://location.services.mozilla.com/leaders#joesph (has #name at the end of the URL), it saves the profile successfully. When I go back to look at the field, it has stripped everything away but joesph. That's expected, correct?

3. I'm wondering if the code should not take #joesph (I typed a # in the field with joesph). I only ask because it will successfully save it with that in the field (no validation error), but when I go to the main page (https://mozillians-dev.allizom.org/en-US/) and mouse-over the #joesph link in the External Accounts section, the URL (at the bottom of the screen from the mouse-over) shows as https://location.services.mozilla.com/leaders##joesph (has two hash signs). It still goes to the correct page in location services, but I'm just wondering if we want to allow putting the # in the edit profile field.
Flags: needinfo?(jgiannelos)
Hey :tericharles thank you for the help!

Regarding comments 1 and 2, it looks like things are working as expected.

About comment 3, it seems to me kind of far fetched. Also the way location.services.mozilla.com constructs the URLs [1] might also cause the same issue (double hash signs) when nickname starts with "#", since the hash sign is hardcoded in the <a> element. I suggest we proceed with what we already have.

[1] https://github.com/mozilla/ichnaea/blob/master/ichnaea/content/templates/leaders.pt#L34
Flags: needinfo?(jgiannelos)
:nemo - Thanks for your replies to my comments!

This looks good to go.
Status: RESOLVED → VERIFIED
Version: next → 2014-12.6
You need to log in before you can comment on or make changes to this bug.