Closed Bug 1106420 Opened 10 years ago Closed 9 years ago

Intermittent apps/system/test/marionette/media_playback_test.js | media playback tests should hide now playing info by exiting

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: philor, Assigned: kgrandon)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

[PullReq] KevinGrandon:bug_1106420_fix_intermittent_unload_error to mozilla-b2g:master
46 bytes, text/x-github-pull-request
gweng
: review+
Details | Review 
      No description provided.
Assignee: nobody → kgrandon
See Also: → 1110913
This is failing way too much, so disabling until we can get it reviewed: https://github.com/mozilla-b2g/gaia/commit/69e0ce4bd24909896fac7689880a30aad659e771
Comment on attachment 8560070 [details] [review]
[PullReq] KevinGrandon:bug_1106420_fix_intermittent_unload_error to mozilla-b2g:master

Greg/Jim - I think I have a pretty solid try run now, could either of you guys review this attempt at fixing the intermittent? Thanks!
Attachment #8560070 - Flags: review?(squibblyflabbetydoo)
Attachment #8560070 - Flags: review?(gweng)
It looks that the code would silent the error. I wonder, although the first version was re-written by me according to the very old tests, if there is some nasty thing occur inside the test code when the error got thrown? If it's not, then maybe the action I used should be fixed, rather than capture the error and make it silent.
NI Kevin for Comment 51.
Flags: needinfo?(kgrandon)
Hey Greg - There is likely some bug in the ensure code here: https://github.com/KevinGrandon/gaia/blob/bug_1106420_fix_intermittent_unload_error/apps/system/test/marionette/lib/ensure.js#L74

It seems like we might be trying to access something in the frame after it's been closed. I unfortunately couldn't figure out *exactly* what that was. I think squelching the error is potentially fine assuming that we have the proper assertions after the close call.

If you have some cycles and want to steal this feel free to, I probably won't be able to dig in further for a few weeks. I also might recommend just trying to land as-is in order to re-enable the tests. I'll leave the final solution up to you guys.
Flags: needinfo?(kgrandon)
OK then I think I could give the r+ and then fire another follow-up bug for that.
Attachment #8560070 - Flags: review?(gweng) → review+
Comment on attachment 8560070 [details] [review]
[PullReq] KevinGrandon:bug_1106420_fix_intermittent_unload_error to mozilla-b2g:master

Thanks Greg. Let's land this for now to re-enable the test and we can file a follow-up for figuring out the root issue.
Attachment #8560070 - Flags: review?(squibblyflabbetydoo)
Keywords: checkin-needed
Depends on: 1132133
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: