If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

SIMD test cases: implement int32x4.bool test case

RESOLVED FIXED in mozilla37

Status

()

Core
JavaScript Engine
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ProgramFOX, Assigned: ProgramFOX)

Tracking

unspecified
mozilla37
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
There is no SIMD test case for the int32x4.bool method.
(Assignee)

Comment 1

3 years ago
Created attachment 8530656 [details] [diff] [review]
Added int32x4.bool test case

Proposed patch that adds a test case for int32x4.bool.
Attachment #8530656 - Flags: review?(benj)
Comment on attachment 8530656 [details] [diff] [review]
Added int32x4.bool test case

Review of attachment 8530656 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, could you try-server it please, update the commit message and add the checkin-needed keyword when it's ready?
Attachment #8530656 - Flags: review?(benj) → review+
(Assignee)

Comment 3

3 years ago
Try push:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ec6743debc57
Assignee: nobody → programfox
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 4

3 years ago
I forgot to run jsreftests on that try push, cancelled it and pushed a new one:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=7a3afa037fc4
(Assignee)

Comment 5

3 years ago
The try push succeeded, adding checkin-needed.

Note that you'll only see the empty patch with the try syntax, but I asked about this on #developers, and birtles said that the try server already had the changes because I pushed the second push quickly after the first one:
http://logs.glob.uno/?c=mozilla%23developers&s=4+Dec+2014&e=4+Dec+2014#c1113113
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8ec192cf912
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c8ec192cf912
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.