1106533 - When adding/changing the Room name in Desktop, a notification is sent for each letter entered

Status: RESOLVED WORKSFORME

(Hello (Loop) :: Client, defect)

Description

[Maria Angeles Oteo (:oteo)]

Right now, when we add or change the Room name in Desktop client in the Room screen, we are sending a PATCH request for each letter entered.

So when we are registered in several devices with the same identity (e.g in a desktop and in a FxOS device) we receive a push notification for every PATCH request which is not optimal

Comment 1

[Maria Angeles Oteo (:oteo)]

Adam, wdyt?

Comment 2

[Mark Banner (:standard8)]

(In reply to Maria Angeles Oteo (:oteo) from comment #0)
> Right now, when we add or change the Room name in Desktop client in the Room
> screen, we are sending a PATCH request for each letter entered.

Where do you see this? The current code should only be sending a request on blur or when pressing enter:

http://hg.mozilla.org/mozilla-central/annotate/08be3008650f/browser/components/loop/content/js/panel.jsx#l524

Comment 3

[Maria Angeles Oteo (:oteo)]

you are right Mark, I've seen this in gecko 36, and after upgrading nightly to gecko 37 is working as you describes.

One minor thing Mark, what I am seeing in nightly is that after changing the Room name in the Room Call screen, the new name is not updated in the Room list.

Comment 4

[Maria Angeles Oteo (:oteo)]

Mark, let me know if you want me to report it or it's already covered in other bug. Cheers

Comment 5

[Mark Banner (:standard8)]

I just split it out to bug 1107210.

Comment 6

[Mark Banner (:standard8)]

Closing this bug as WFM.