Closed
Bug 1106538
Opened 9 years ago
Closed 9 years ago
When deleting a Room in Firefox Hello Desktop, the Room is not removed from the Conversation list
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox35? fixed, firefox36 fixed, firefox37 fixed)
backlog | Fx35+ |
People
(Reporter: oteo, Assigned: standard8)
References
Details
(Keywords: regression)
Attachments
(1 file)
3.49 KB,
patch
|
NiKo
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
After removing a Room from the Conversation list in Firefox Hello application and confirming the action, the user can not join the Room anymore but the Room entry is not removed from the conversation list
Reporter | ||
Updated•9 years ago
|
status-firefox37:
--- → affected
Assignee | ||
Comment 1•9 years ago
|
||
Ok, this is a regression, sort-of, as we're relying on version 0.14 of the server that isn't out yet. We're also relying on push notifications to get us the update for the local user. I think I know what to do to restore this - its something I took out in bug 1089722 but wasn't 100% sure if we wanted to keep it or not at the time.
Assignee: nobody → standard8
Blocks: 1089722
Keywords: regression
OS: Mac OS X → All
Hardware: x86 → All
Assignee | ||
Updated•9 years ago
|
backlog: --- → Fx35+
Priority: -- → P1
Comment 2•9 years ago
|
||
[Tracking Requested - why for this release]: We need this fix for the first release of Rooms
tracking-firefox35:
--- → ?
Assignee | ||
Comment 5•9 years ago
|
||
This puts the event back in that bug 1089722 removed. It does mean we effectively get double-delete events, but we handle it correctly, even if the server fails to give us a push notification afterwards (and there's quicker user feedback).
Attachment #8531666 -
Flags: review?(nperriault)
Comment on attachment 8531666 [details] [diff] [review] When deleting a room, the room is not removed from the conversation list - add a notification of the delete completing. Review of attachment 8531666 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. ::: browser/components/loop/test/xpcshell/test_looprooms.js @@ +396,5 @@ > > +// Test if deleting a room works as expected. > +add_task(function* test_deleteRoom() { > + let roomToken = "QzBbvGmIZWU"; > + gExpectedDeletes.push("QzBbvGmIZWU"); Nit: How about gExpectedDeletes.push(roomToken)?
Attachment #8531666 -
Flags: review?(nperriault) → review+
Assignee | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/42ce3ca2e600
Iteration: --- → 37.1
Points: --- → 1
Target Milestone: --- → mozilla37
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/42ce3ca2e600
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 11•9 years ago
|
||
Comment on attachment 8531666 [details] [diff] [review] When deleting a room, the room is not removed from the conversation list - add a notification of the delete completing. Approval Request Comment [Feature/regressing bug #]: bug 1089722 Landed on m-c right before uplift to aurora [User impact if declined]: broken delete behavior on Aurora, no user confirmation of delete (blocks bug 1092953) [Describe test coverage new/current, TBPL]: On m-c and tested by me both on m-c and with the delete code [Risks and why]: Very simple and simply undoes some stuff removed in bug 1089722 (so we're not dependent on an unreleased version of the server). [String/UUID change made/needed]: none
Attachment #8531666 -
Flags: approval-mozilla-beta?
Attachment #8531666 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
status-firefox35:
--- → affected
status-firefox36:
--- → affected
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8531666 -
Flags: approval-mozilla-beta?
Attachment #8531666 -
Flags: approval-mozilla-beta+
Attachment #8531666 -
Flags: approval-mozilla-aurora?
Attachment #8531666 -
Flags: approval-mozilla-aurora+
Updated•9 years ago
|
Flags: in-testsuite+
Updated•9 years ago
|
Comment 14•9 years ago
|
||
tested extensively on linux64
Comment 15•9 years ago
|
||
Maria, this should be fixed in the latest Nightly, Aurora, and Beta builds.
Flags: qe-verify-
Flags: needinfo?(oteo)
Reporter | ||
Comment 16•9 years ago
|
||
yes, it's working fine! Thanks a lot Anthony
Flags: needinfo?(oteo)
You need to log in
before you can comment on or make changes to this bug.
Description
•