1106538 - When deleting a Room in Firefox Hello Desktop, the Room is not removed from the Conversation list

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Maria Angeles Oteo (:oteo)]

After removing a Room from the Conversation list in Firefox Hello application and confirming the action, the user can not join the Room anymore but the Room entry is not removed from the conversation list

Comment 1

[Mark Banner (:standard8)]

Ok, this is a regression, sort-of, as we're relying on version 0.14 of the server that isn't out yet.

We're also relying on push notifications to get us the update for the local user.

I think I know what to do to restore this - its something I took out in bug 1089722 but wasn't 100% sure if we wanted to keep it or not at the time.

Comment 2

[Maire Reavy [:mreavy]]

[Tracking Requested - why for this release]:
We need this fix for the first release of Rooms

Comment 5

[Mark Banner (:standard8)]

Attachment: When deleting a room, the room is not removed from the conversation list - add a notification of the delete completing.

This puts the event back in that bug 1089722 removed. It does mean we effectively get double-delete events, but we handle it correctly, even if the server fails to give us a push notification afterwards (and there's quicker user feedback).

Comment 6

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8531666 [details] [diff] [review]
When deleting a room, the room is not removed from the conversation list - add a notification of the delete completing.

Review of attachment 8531666 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: browser/components/loop/test/xpcshell/test_looprooms.js
@@ +396,5 @@
>  
> +// Test if deleting a room works as expected.
> +add_task(function* test_deleteRoom() {
> +  let roomToken = "QzBbvGmIZWU";
> +  gExpectedDeletes.push("QzBbvGmIZWU");

Nit: How about gExpectedDeletes.push(roomToken)?

Comment 7

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/42ce3ca2e600

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/42ce3ca2e600

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8531666 [details] [diff] [review]
When deleting a room, the room is not removed from the conversation list - add a notification of the delete completing.

Approval Request Comment
[Feature/regressing bug #]: bug 1089722
Landed on m-c right before uplift to aurora

[User impact if declined]: broken delete behavior on Aurora, no user confirmation of delete (blocks bug 1092953)

[Describe test coverage new/current, TBPL]: On m-c and tested by me both on m-c and with the delete code

[Risks and why]: Very simple and simply undoes some stuff removed in bug 1089722 (so we're not dependent on an unreleased version of the server).

[String/UUID change made/needed]: none

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/97864830c61d

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/87977ec7b767

Comment 14

[Randell Jesup [:jesup] (needinfo me)]

tested extensively on linux64

Comment 15

[u279076]

Maria, this should be fixed in the latest Nightly, Aurora, and Beta builds.

Comment 16

[Maria Angeles Oteo (:oteo)]

yes, it's working fine! Thanks a lot Anthony

Comment 17

[u279076]

Thank you, Maria.