1106544 - expanding app group at bottom of screen should scroll it completely into visible screen area

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Expanding an app group at the bottom of a screen should scroll it completely into the visible screen area.

Steps to reproduce:
1. Create app groups until the screen can be scrolled while the last app group is collapsed.
2. Scroll to the bottom.
3. Expand the last app group.

Actual result:
Expanded, big icons partially off-screen (for >4 icons likely some icons totally off-screen). Can also happen for groups higher up if there are enough apps in it, I guess.

Expected result:
Scroll up until all apps in the group are shown or the vertical start of the app group reaches the top of the screen.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1106544-focus-expanding-groups > mozilla-b2g:master

Comment 2

[Chris Lord [:cwiiis]]

Comment on attachment 8573257 [details] [review]
[gaia] Cwiiis:bug1106544-focus-expanding-groups > mozilla-b2g:master

Although this is simple conceptually, it ended up being a bit larger than expected because 1- Groups don't return their correct position/size when expanded (and so requestAttention had to be overridden), and 2- The handling of gaiagrid-attention in verticalhome didn't work out the exact right offsets when not in edit mode (and I'm a stickler for details).

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8573257 [details] [review]
[gaia] Cwiiis:bug1106544-focus-expanding-groups > mozilla-b2g:master

Code looks good, and works great on a device. Left a comment on github to see if we can avoid the inner setTimeout. If you can't change no worries, but really not a fan of the 20ms timeouts.

Loads of reviews today, trying to get through everything but might take me a bit of time.

Comment 4

[Chris Lord [:cwiiis]]

And today this has stopped working for me? Ugh...

Anyway, looking for something to replace the 20ms timeouts - possibly rAf(rAf(callback)) I think, but still experimenting...

Comment 5

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#fu_BQ3gpRceqIEkZW9oxSw

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 6

[Kevin Grandon :kgrandon]

(In reply to Autolander from comment #5)
> The pull request failed to pass integration tests. It could not be landed,
> please try again.

Also looks like there's a 'Gu' failure... Definitely clear that up before landing.

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/b93ee2a990687679d45f31a2f36e863a0e34d942

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with B2G 3.0 20150311125826 on Flame (v18D base image).

Comment 9

[Chris Lord [:cwiiis]]

Comment on attachment 8573257 [details] [review]
[gaia] Cwiiis:bug1106544-focus-expanding-groups > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Sub-optimal behaviour when expanding any large group, small polish issue. I think this also fixes some edge-cases in code that responds to attention requests from GaiaGrid in the homescreen.
[Testing completed]: Manual testing, partially covered by automated testing and been on master for a while with no issues.
[Risk to taking this patch] (and alternatives if risky): Low risk.
[String changes made]: None.

Comment 10

[Hermes Cheng (inactive after July 27, 2015)]

NI myself for following verification.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/00360077eda5ad02be2be97f13167a8ad6c700d5

Comment 12

[Hermes Cheng (inactive after July 27, 2015)]

verify master & 2.2 branch

* 2.2
Build ID               20150323162503
Gaia Revision          e54c4ed1cc188f70ddf1156534d364005dc45490
Gaia Date              2015-03-23 19:09:26
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/7ba1778d237b
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150323.200543
Firmware Date          Mon Mar 23 20:05:54 EDT 2015
Bootloader             L1TC000118D0

* master
Build ID               20150323010204
Gaia Revision          9b6f3024e4d0e62dd057231f4b14abe1782932ab
Gaia Date              2015-03-22 10:09:18
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e730012260a4
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150323.043448
Firmware Date          Mon Mar 23 04:34:57 EDT 2015
Bootloader             L1TC100118D0