1106586 - Make rocketfuel public APIs use feed collections

Status: VERIFIED FIXED

(Marketplace Graveyard :: API, defect, P2)

Description

[Mathieu Pillard [:mat]]

Tarako Marketplace still uses rocketfuel fireplace API to fetch the apps for its homepage - /api/v1/fireplace/collection/tarako-featured/

We need to make this API use feed collections instead, so that we can remove all remaining rocketfuel code.

Comment 1

[Mathieu Pillard [:mat]]

https://github.com/mozilla/zamboni/pull/2762

Comment 2

[krupa raj[:krupa]]

Right now, the tarako feed created at https://marketplace-dev.allizom.org/curate/manage/collections/tarako-featured is the collection i'm expecting to show up on my tarako collection.

But on my tarako device, launching the marketplace-dev packaged app, results in a GET 0 due to CORS failure, because of which I do not see the newer collection.

12-09 19:29:14.530 E/GeckoConsole(  465): Content JS LOG at app://packaged.marketplace-dev.allizom.org/media/js/include.js:3 in l/s/<: [req] Intermittent CORS failure, retrying request once https://marketplace-dev.mozflare.net/api/v1/fireplace/collection/tarako-featured/?cache=1&carrier=deutsche_telekom&dev=firefoxos&device=firefoxos&lang=en-US&limit=10&region=us&vary=0
12-09 19:29:14.580 E/GeckoConsole(  465): Content JS LOG at app://packaged.marketplace-dev.allizom.org/media/js/include.js:3 in l/s/<: [req] Request failed: GET 0
12-09 19:29:14.590 E/GeckoConsole(  465): Content JS LOG at app://packaged.marketplace-dev.allizom.org/media/js/include.js:4 in d: [object XrayWrapper [object XMLHttpRequest]]
12-09 19:29:14.590 E/GeckoConsole(  465): Content JS LOG at app://packaged.marketplace-dev.allizom.org/media/js/include.js:3 in l/s/<: [req] Intermittent CORS failure, retrying request once https://marketplace-dev.mozflare.net/api/v1/fireplace/collection/tarako-featured/?cache=1&carrier=deutsche_telekom&dev=firefoxos&device=firefoxos&lang=en-US&limit=10&region=us&vary=0
12-09 19:29:14.660 E/GeckoConsole(  465): Content JS LOG at app://packaged.marketplace-dev.allizom.org/media/js/include.js:3 in l/s/<: [req] Request failed: GET 0
12-09 19:29:14.660 E/GeckoConsole(  465): Content JS LOG at app://packaged.marketplace-dev.allizom.org/media/js/include.js:4 in d: [object XrayWrapper [object XMLHttpRequest]]
12-09 19:29:14.660 E/GeckoConsole(  465): Content JS LOG at app://packaged.marketplace-dev.allizom.org/media/js/include.js:3 in l/s/<: [req] Intermittent CORS failure, retrying request once https://marketplace-dev.mozflare.net/api/v1/fireplace/collection/tarako-featured/?cache=1&carrier=deutsche_telekom&dev=firefoxos&device=firefoxos&lang=en-US&limit=10&region=us&vary=0
12-09 19:29:14.690 E/GeckoConsole(  465): Content JS LOG at app://packaged.marketplace-dev.allizom.org/media/js/include.js:3 in l/s/<: [req] Request failed: GET 0
12-09 19:29:14.700 E/GeckoConsole(  465): Content JS LOG at app://packaged.marketplace-dev.allizom.org/media/js/include.js:4 in d: [object XrayWrapper [object XMLHttpRequest]]

Comment 3

[Mathieu Pillard [:mat]]

https://github.com/mozilla/zamboni/pull/2772 should fix this.

Comment 4

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/e95b0eb7b906097069b05de0a7210ad7867050a9

The GET 0 should be gone now on dev.

Comment 5

[Victor Carciu]

The error is not displayed anymore, but I can see only first 10 apps from the 11 app featured tarako collection : https://marketplace-dev.allizom.org/curate/manage/collections/tarako-featured 

You can see that last app is Chrono Cash instead of Face Value: http://screencast.com/t/YcXFQBCd

Comment 6

[Mathieu Pillard [:mat]]

I double-checked and this was by design, the homepage in yogafire is never supposed to display more than 10 apps.

Comment 7

[Victor Carciu]

Thank you ! Verified as fixed