Closed
Bug 1106600
Opened 10 years ago
Closed 10 years ago
Fix the clang -Wstring-conversion warnings about PR_ASSERT(!"foo")
Categories
(NSPR :: NSPR, defect, P2)
NSPR
NSPR
Tracking
(Not tracked)
RESOLVED
FIXED
4.10.8
People
(Reporter: wtc, Assigned: wtc)
Details
Attachments
(1 file)
|
15.15 KB,
patch
|
thakis
:
review+
|
Details | Diff | Splinter Review |
This bug was originally reported in the Chromium code review at https://codereview.chromium.org/762483003/ The proposed patch changes PR_ASSERT(!"foo") to PR_NOT_REACHED("foo"). The only exception is pr/tests/multiwait.c, which defines its own assertion macro MW_ASSERT. I fixed MW_ASSERT(!"foo") by using MW_ASSERT(PR_FALSE && "foo").
Attachment #8530924 -
Flags: review?(thakis)
Comment on attachment 8530924 [details] [diff] [review] Replace PR_ASSERT(!"foo") with PR_NOT_REACHED("foo") Review of attachment 8530924 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8530924 -
Flags: review?(thakis) → review+
|
Assignee | |
Updated•10 years ago
|
Severity: normal → trivial
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•