Closed Bug 1106627 Opened 10 years ago Closed 10 years ago

Remove strings from STK/ICC content

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

Details

Attachments

(1 file)

[PullReq] KevinGrandon:bug_1106627_stk_icc_strings to mozilla-b2g:master
46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review 
And there is some weird usage of the data-l10n-ids that we should fix.
Comment on attachment 8530960 [details] [review]
[PullReq] KevinGrandon:bug_1106627_stk_icc_strings to mozilla-b2g:master

Fernando or Tim - could you guys review this?

It seems weird that we are setting static l10n ids when they could just be assigned to the content in the first place. Thanks!
Attachment #8530960 - Flags: review?(timdream)
Attachment #8530960 - Flags: review?(frsela)
Comment on attachment 8530960 [details] [review]
[PullReq] KevinGrandon:bug_1106627_stk_icc_strings to mozilla-b2g:master

Thanks!
Attachment #8530960 - Flags: review?(timdream)
Attachment #8530960 - Flags: review?(frsela)
Attachment #8530960 - Flags: review+
Component: Gaia → Gaia::System
Keywords: checkin-needed
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: