Update storage path for b2gpopulate due to bug 1083927

RESOLVED FIXED

Status

Testing
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: davehunt, Assigned: davehunt)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
In bug 1083927 the storage path was changed from 'persistent' to 'permanent'. In order for b2gpopulate master branch to be compatible with trunk builds we need to update this.
(Assignee)

Comment 1

3 years ago
Created attachment 8530961 [details] [review]
Link to Github pull-request: https://github.com/mozilla/b2gpopulate/pull/29
Attachment #8530961 - Flags: review?(wlachance)
Comment on attachment 8530961 [details] [review]
Link to Github pull-request: https://github.com/mozilla/b2gpopulate/pull/29

Looks fine by me
Attachment #8530961 - Flags: review?(wlachance) → review+
(Assignee)

Comment 3

3 years ago
Comment on attachment 8530961 [details] [review]
Link to Github pull-request: https://github.com/mozilla/b2gpopulate/pull/29

Turns out that call log and events were still broken (see bug 1108008 for details). I've updated the pull request to cater for these.
Attachment #8530961 - Flags: review+ → review?(wlachance)
Comment on attachment 8530961 [details] [review]
Link to Github pull-request: https://github.com/mozilla/b2gpopulate/pull/29

Looks fine. Just noticed something about the path concatenation but that's an old issue.
Attachment #8530961 - Flags: review?(wlachance) → review+
(Assignee)

Comment 5

3 years ago
Comment on attachment 8530961 [details] [review]
Link to Github pull-request: https://github.com/mozilla/b2gpopulate/pull/29

I added a commit to switch to posixpath.
Attachment #8530961 - Flags: review+ → review?(wlachance)
Comment on attachment 8530961 [details] [review]
Link to Github pull-request: https://github.com/mozilla/b2gpopulate/pull/29

LGTM!
Attachment #8530961 - Flags: review?(wlachance) → review+
(Assignee)

Comment 7

3 years ago
Landed in:
https://github.com/mozilla/b2gpopulate/commit/d4049028b83ff0888cb0b891010e7fdc17c955ec
https://github.com/mozilla/b2gpopulate/commit/de7806d8410100ec9675a8c42b6d9ae7c56ed4f0

Released as:
https://pypi.python.org/pypi/b2gpopulate/0.29

Tagged as:
https://github.com/mozilla/b2gpopulate/releases/tag/0.29
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.