1106629 - Update storage path for b2gpopulate due to bug 1083927

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

In bug 1083927 the storage path was changed from 'persistent' to 'permanent'. In order for b2gpopulate master branch to be compatible with trunk builds we need to update this.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Link to Github pull-request: https://github.com/mozilla/b2gpopulate/pull/29

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8530961 [details] [review]
Link to Github pull-request: https://github.com/mozilla/b2gpopulate/pull/29

Looks fine by me

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8530961 [details] [review]
Link to Github pull-request: https://github.com/mozilla/b2gpopulate/pull/29

Turns out that call log and events were still broken (see bug 1108008 for details). I've updated the pull request to cater for these.

Comment 4

[William Lachance (:wlach)]

Comment on attachment 8530961 [details] [review]
Link to Github pull-request: https://github.com/mozilla/b2gpopulate/pull/29

Looks fine. Just noticed something about the path concatenation but that's an old issue.

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8530961 [details] [review]
Link to Github pull-request: https://github.com/mozilla/b2gpopulate/pull/29

I added a commit to switch to posixpath.

Comment 6

[William Lachance (:wlach)]

Comment on attachment 8530961 [details] [review]
Link to Github pull-request: https://github.com/mozilla/b2gpopulate/pull/29

LGTM!

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed in:
https://github.com/mozilla/b2gpopulate/commit/d4049028b83ff0888cb0b891010e7fdc17c955ec
https://github.com/mozilla/b2gpopulate/commit/de7806d8410100ec9675a8c42b6d9ae7c56ed4f0

Released as:
https://pypi.python.org/pypi/b2gpopulate/0.29

Tagged as:
https://github.com/mozilla/b2gpopulate/releases/tag/0.29