Javascript error in network manager when setting up DUN data call

RESOLVED FIXED in 2.2 S3 (9jan)

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: pgravel, Assigned: edgar)

Tracking

({regression})

unspecified
2.2 S3 (9jan)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:2.2+, b2g-v2.2 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

5 years ago
[Blocking Requested - why for this release]: regression

Undefined variable error when trying to setup a DUN data call in NetworkManager.js

> W GeckoConsole: [JavaScript Error: "ReferenceError: ril is not defined" {file: "jar:file:///system/b2g/omni.ja!/components/NetworkManager.js" line: 889}]

Change that introduced the error: http://hg.mozilla.org/mozilla-central/rev/328c344675c5
Assignee: nobody → echen
Blocks: 843452
Keywords: regression
Looks bad and should block as it's regression.
Apart from that, can someone elaborate a little more how this impacts end user? (ex: data connection fails with high probability)
Just want to get some more information before making "blocking" decision.
(In reply to Wesley Huang [:wesley_huang] (EPM) (NI me) from comment #1)
> Looks bad and should block as it's regression.
> Apart from that, can someone elaborate a little more how this impacts end
> user? (ex: data connection fails with high probability)
> Just want to get some more information before making "blocking" decision.

The impact is end user cannot use tethering if the device is using dun apn for tethering.
blocking-b2g: 2.2? → 2.2+
OS: Linux → Gonk (Firefox OS)
Hardware: x86 → ARM
Target Milestone: --- → 2.2 S3 (9jan)
Posted patch Patch, v1 (obsolete) — Splinter Review
Posted patch Patch, v2Splinter Review
Attachment #8539972 - Attachment is obsolete: true
Comment on attachment 8541134 [details] [diff] [review]
Patch, v2

Review of attachment 8541134 [details] [diff] [review]:
-----------------------------------------------------------------

Besides the error mentioned in comment #0, I also fix anther typo regarding to DUN type,
- s/NETWORK_TYPE_DUN/NETWORK_TYPE_MOBILE_DUN/

I have tested hotspot + dun connection manually, it works good after applying this patch.

Hi Hsinyi, may I have your review? Thank you.
Attachment #8541134 - Flags: review?(htsai)
(In reply to Edgar Chen [:edgar][:echen] from comment #5)
> Comment on attachment 8541134 [details] [diff] [review]
> Patch, v2
> 
> Review of attachment 8541134 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Besides the error mentioned in comment #0, I also fix anther typo regarding
> to DUN type,
> - s/NETWORK_TYPE_DUN/NETWORK_TYPE_MOBILE_DUN/
> 
> I have tested hotspot + dun connection manually, it works good after
> applying this patch.

Oops, typo introduced in bug 1058305, we should add test cases for dun. :( Bug 1115299 filed!

> 
> Hi Hsinyi, may I have your review? Thank you.
Comment on attachment 8541134 [details] [diff] [review]
Patch, v2

Review of attachment 8541134 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, thank you.
Attachment #8541134 - Flags: review?(htsai) → review+
https://hg.mozilla.org/mozilla-central/rev/987a266fd928
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.