Closed
Bug 1106656
Opened 9 years ago
Closed 9 years ago
Javascript error in network manager when setting up DUN data call
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(blocking-b2g:2.2+, b2g-v2.2 fixed)
Tracking | Status | |
---|---|---|
b2g-v2.2 | --- | fixed |
People
(Reporter: pgravel, Assigned: edgar)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
2.19 KB,
patch
|
hsinyi
:
review+
|
Details | Diff | Splinter Review |
[Blocking Requested - why for this release]: regression Undefined variable error when trying to setup a DUN data call in NetworkManager.js > W GeckoConsole: [JavaScript Error: "ReferenceError: ril is not defined" {file: "jar:file:///system/b2g/omni.ja!/components/NetworkManager.js" line: 889}] Change that introduced the error: http://hg.mozilla.org/mozilla-central/rev/328c344675c5
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → echen
Assignee | ||
Updated•9 years ago
|
Blocks: 843452
Keywords: regression
Comment 1•9 years ago
|
||
Looks bad and should block as it's regression. Apart from that, can someone elaborate a little more how this impacts end user? (ex: data connection fails with high probability) Just want to get some more information before making "blocking" decision.
Assignee | ||
Comment 2•9 years ago
|
||
(In reply to Wesley Huang [:wesley_huang] (EPM) (NI me) from comment #1) > Looks bad and should block as it's regression. > Apart from that, can someone elaborate a little more how this impacts end > user? (ex: data connection fails with high probability) > Just want to get some more information before making "blocking" decision. The impact is end user cannot use tethering if the device is using dun apn for tethering.
Updated•9 years ago
|
blocking-b2g: 2.2? → 2.2+
Assignee | ||
Updated•9 years ago
|
OS: Linux → Gonk (Firefox OS)
Hardware: x86 → ARM
Target Milestone: --- → 2.2 S3 (9jan)
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8539972 -
Attachment is obsolete: true
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8541134 [details] [diff] [review] Patch, v2 Review of attachment 8541134 [details] [diff] [review]: ----------------------------------------------------------------- Besides the error mentioned in comment #0, I also fix anther typo regarding to DUN type, - s/NETWORK_TYPE_DUN/NETWORK_TYPE_MOBILE_DUN/ I have tested hotspot + dun connection manually, it works good after applying this patch. Hi Hsinyi, may I have your review? Thank you.
Attachment #8541134 -
Flags: review?(htsai)
Comment 6•9 years ago
|
||
(In reply to Edgar Chen [:edgar][:echen] from comment #5) > Comment on attachment 8541134 [details] [diff] [review] > Patch, v2 > > Review of attachment 8541134 [details] [diff] [review]: > ----------------------------------------------------------------- > > Besides the error mentioned in comment #0, I also fix anther typo regarding > to DUN type, > - s/NETWORK_TYPE_DUN/NETWORK_TYPE_MOBILE_DUN/ > > I have tested hotspot + dun connection manually, it works good after > applying this patch. Oops, typo introduced in bug 1058305, we should add test cases for dun. :( Bug 1115299 filed! > > Hi Hsinyi, may I have your review? Thank you.
Comment 7•9 years ago
|
||
Comment on attachment 8541134 [details] [diff] [review] Patch, v2 Review of attachment 8541134 [details] [diff] [review]: ----------------------------------------------------------------- Good catch, thank you.
Attachment #8541134 -
Flags: review?(htsai) → review+
Assignee | ||
Comment 8•9 years ago
|
||
Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=46fbbd33c27c
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/987a266fd928
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/987a266fd928
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
status-b2g-v2.2:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•