1106664 - [Midori 2.0][Wi-Fi]Wi-Fi can't work normally after connecting to WPA-EAP AP

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Wifi, defect, P2)

Description

[sync-1]

Created an attachment (id=1043730)
 LOG
 Mozilla Build ID: 20141019000201
 DEFECT DESCRIPTION:
 Wi-Fi can't work normally after connect WPA-EAP AP
 
  REPRODUCING PROCEDURES:
 1.connect to WPA-EAP-SIM AP 
 2.connect to Littlecat when the phone is connecting to WPA-EAP-SIM AP 
 3.can't connect to Littlecat AP->KO
 3.Wi-Fi can't work normally(can't close and open)-->KO
 
 中文：
 1.手机要去连接WPA-EAP-SIM AP
 2.当手机在连接此AP过程中，再去连接另一个AP Littlecat
 3.手机连接不上Littlecat->KO
 4.想去关掉Wi-Fi也关闭不了了，一直停在如附件所示界面->KO
  EXPECTED BEHAVIOUR:
 Wi-Fi can work normally after connect WPA-EAP AP
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Attachment: LOG

Comment 2

[sync-1]

Attachment: PIC

Comment 3

[Wang Rong]

from the log, it seems supplicant crashed when connect to EAP-SIM ap.

Comment 4

[Wang Rong]

[Blocking Requested - why for this release]:block TA.

when connect to WPA-EAP ap as a known ap, eap method will be set to null, it caused supplicant crash. Please fix it.

Comment 5

[Wesly Huang (EPM)]

Hi Wang Rong, would you help clarify if this is seen in 1.3 as well, also the result w/ Flame 2.0 so we know this is not device-specific? Thanks.

qawanted for 2.1 & 2.2.

Comment 6

[Wang Rong]

eap sim is not supported on 1.3 so we hide all eap sim related UI.

Comment 7

[Wesly Huang (EPM)]

Hi Norry:

Would you help verify this issue w/ Flame on 2.1 and 2.2?

@Wang Rong:

How about your verify result on Flame w/ 2.0?

Comment 8

[Hubert Lu[:hlu] <[e-mail]>]

Hi Wesly,
   Flame does not support EAP-SIM.

Comment 9

[Wesly Huang (EPM)]

Hi Vincent:

As discussed, would you help check this issue? Thank you.

Comment 10

[Wesly Huang (EPM)]

[Triage] need to validate this issue first.

Comment 11

[Vincent Chang[:vchang][changyihsin]]

(In reply to Wang Rong from comment #4)
> [Blocking Requested - why for this release]:block TA.
> 
> when connect to WPA-EAP ap as a known ap, eap method will be set to null, it
> caused supplicant crash. Please fix it.

Hi Wang, do you mean key param "eap" is not correctly set in wpa_supplicant.conf? Can you help to check it in settings app before calling associate APIs? I check the current implementation in [1]. It looks fine for me.  

network={
ssid="eapsim"
key_mgmt=WPA-EAP
eap=SIM
} 

BTW, you can disable eap-sim if your platform(wpa_supplicant) doesn't support it [2]. 

[1] http://mxr.mozilla.org/gaia/source/shared/js/wifi_helper.js#13
[2] http://dxr.mozilla.org/mozilla-central/source/dom/wifi/WifiWorker.js?from=wifiworker.js%20#117

NI? EJ if you need further information from settings app.

Comment 12

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Because Flame doesn't support EAP-SIM, so please help to dump information from Settings app and let's see what's wrong there.

Checked from log, it seems that `wifiManager.getKnownNetworks()` was broken but the line number doesn't match the one from our source code, did you change wifi.js ? 

BTW, It would be better to dump the log from code directly to narrow down the problem instead of attaching the whole log.

Comment 13

[Kai-Chih Hu [:khu]]

ni to the reporter.

Comment 14

[Jack Liu]

ni Wangrong the reporter.

Comment 15

[Wang Rong]

Yes, we check the wpa_supplicant.conf and find that eap is not set then it is null and causes wpa_supplicant crash.

Comment 16

[Vincent Chang[:vchang][changyihsin]]

(In reply to Wang Rong from comment #15)
> Yes, we check the wpa_supplicant.conf and find that eap is not set then it
> is null and causes wpa_supplicant crash.

Can you also add some debug logs per comment 12? I assume that you have customized the setting app?

Comment 17

[Wesly Huang (EPM)]

Hi Wang Rong, would you confirm you have fix this issue per comment#15? If not then pls provide more information per comment#12 so we can check if this is general OS issue. Thanks.

Comment 18

[Wang Rong]

It has been fixed. Thanks.

Comment 19

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Sorry, can you put more details about how this bug happened and how this one got fixed ?

Comment 20

[Wesly Huang (EPM)]

[Triage] de-tag, also tend to be POVB?


Hi Wang Rong: 

Would you let us know how did you fix this issue? Thank you.

Comment 21

[Wang Rong]

we have do the customization of remembering passwords of networks. when connect eap-peap network with wrong password then connect to other normal networks with wrong password, then close wifi and open wifi, it happend.

About how it fixed, at the very start, we added codes in supplicant to check if eap is null, it null, return. This change avoids supplicant crash but can't fix the bug fundamentally.
Then we modified codes in gecko and gaia to make sure the eap value can be set correctly and saved in wpa_supplicant.conf, it works and problem is fixed.

Comment 22

[Vincent Chang[:vchang][changyihsin]]

(In reply to Wang Rong from comment #21)
> we have do the customization of remembering passwords of networks. when
> connect eap-peap network with wrong password then connect to other normal
> networks with wrong password, then close wifi and open wifi, it happend.
> 
> About how it fixed, at the very start, we added codes in supplicant to check
> if eap is null, it null, return. This change avoids supplicant crash but
> can't fix the bug fundamentally.
> Then we modified codes in gecko and gaia to make sure the eap value can be
> set correctly and saved in wpa_supplicant.conf, it works and problem is
> fixed.

Hi Wang Rong, good to know that the bug is fixed. Do you think you can contribute back your gecko/gaia patches? We can help to review and commit to mozilla code base. Thanks in advance.

Comment 23

[BMO Automation]

Firefox OS is not being worked on