Open
Bug 1106681
Opened 11 years ago
Updated 3 years ago
The ConvertState method of SwitchHandlerHeadphone class is not general enough
Categories
(Core :: Hardware Abstraction Layer (HAL), defect)
Tracking
()
NEW
People
(Reporter: sunhaitao, Unassigned)
Details
Attachments
(1 file)
|
636 bytes,
patch
|
Details | Diff | Splinter Review |
Currently it convert any state except 0 and 1 to SWITCH_STATE_HEADPHONE.
But on some device (e.g many of Allwinner A23-based Tablets) , the initial state after booting is -1.
I believe we should convert all states except 0, 1 and 2 to SWITCH_STATE_UNKNOWN.
|
Reporter | |
Comment 1•11 years ago
|
||
Is there any test code required? I haven't found any existing one to extend.
Attachment #8531074 -
Flags: review?(justin.lebar+bug)
|
||
Comment 2•11 years ago
|
||
Hi, I don't work on Mozilla stuff anymore; please find another reviewer.
|
|
Reporter | |
Comment 3•11 years ago
|
||
Comment on attachment 8531074 [details] [diff] [review]
A Working Patch
(In reply to Justin Lebar (not reading bugmail) from comment #2)
> Hi, I don't work on Mozilla stuff anymore; please find another reviewer.
Sorry...
Attachment #8531074 -
Flags: review?(justin.lebar+bug) → review?(mounir)
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8531074 [details] [diff] [review]
A Working Patch
Dropping review request because it was two years ago. If you still want to hear from me, please add the flag back.
Attachment #8531074 -
Flags: review?(mounir)
|
||
Updated•3 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•