1106710 - [SmartData] Adding parameters needed for the 'customize' plan type

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Marina Rodríguez [:mai]]

The 'customize' plan type need the following fields to be configured by the user:

  * Starting date
  * Duration

Comment 1

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Hi Salva,
Would you mind reviewing the patch?, on this patch I've only added the parameters to the config and ui. I'm going to open a follow-up bug to implement the behaviour of this new plan.
Regards

Comment 2

[Salvador de la Puente González [:salva]]

Comment on attachment 8531997 [details] [review]
patch v1.0

It looks great but if we land this we will end with unusable functionality in master sou we should provide a flag into settings to hide all this functionality until it's totally complete. Add that flag, address the issues on GitHub and ask for my review again. Thank you Mai, good work!

Comment 3

[Marina Rodríguez [:mai]]

Hi Salva, 
Currently, I'm working on the follow-up bug (1107464) that it provides the functionality. I want to land both patch at the same time on master. I split the bug in two beause it's easier the reviewing of them. If you prefer it, we can join both bugs before landing on master.
Regards

Comment 4

[Marina Rodríguez [:mai]]

Comment on attachment 8531997 [details] [review]
patch v1.0

Hi Salva,
would you mind reviewing the patch?
Regards

Comment 5

[Salvador de la Puente González [:salva]]

Comment on attachment 8531997 [details] [review]
patch v1.0

If possible, I would have preferred to first change the data model to keep both `resetTime` and `startingDate` (which we should rename to something as `startTime` and `endTime` making it obvious we are referring to the bounds of the period.

The we could add the UI changes. Address the problems on GitHub and let's try to discuss this offline.

Thank you Mai!

Comment 6

[Salvador de la Puente González [:salva]]

Comment on attachment 8531997 [details] [review]
patch v1.0

Lets convert this bug into a META as accorded offline. Removing the review flag.

Comment 7

[BMO Automation]

Firefox OS is not being worked on