Closed
Bug 1106720
Opened 9 years ago
Closed 9 years ago
Intermittent test_bug1096146.html | verify result - got 3, expected 1
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
Tracking | Status | |
---|---|---|
firefox35 | --- | unaffected |
firefox36 | --- | fixed |
firefox37 | --- | fixed |
firefox-esr31 | --- | unaffected |
b2g-v2.1 | --- | unaffected |
b2g-v2.2 | --- | fixed |
People
(Reporter: cbook, Assigned: gyeh)
References
()
Details
(Keywords: intermittent-failure)
Attachments
(1 file, 2 obsolete files)
3.76 KB,
patch
|
gyeh
:
review+
|
Details | Diff | Splinter Review |
Ubuntu VM 12.04 x64 fx-team debug test mochitest-e10s-1 https://treeherder.mozilla.org/ui/logviewer.html#?job_id=1334020&repo=fx-team 01:22:46 INFO - 1391 INFO TEST-UNEXPECTED-FAIL | /tests/dom/events/test/test_bug1096146.html | verify result - got 3, expected 1
Reporter | ||
Updated•9 years ago
|
OS: Mac OS X → Linux
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 3•9 years ago
|
||
Seems like we need to increase the timer.
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 5•9 years ago
|
||
try: https://tbpl.mozilla.org/?tree=Try&rev=8a4f54e12284
Assignee | ||
Comment 6•9 years ago
|
||
I triggered the mochitest manually on try server (more than ten times), and no intermittent failure happens.
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8534382 [details] [diff] [review] Patch 1(v1): Increase timeout Review of attachment 8534382 [details] [diff] [review]: ----------------------------------------------------------------- smaug, please check the patch. Thanks.
Attachment #8534382 -
Flags: review?(bugs)
Comment 8•9 years ago
|
||
Comment on attachment 8534382 [details] [diff] [review] Patch 1(v1): Increase timeout For this particular test, a safer option might be to wait until we have enough events (3), and once we have, then have still one more timeout to check that we don't get more. But this might be enough.
Attachment #8534382 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 9•9 years ago
|
||
Nice suggestion!
Assignee | ||
Comment 10•9 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #8) > For this particular test, a safer option might be to wait until we have > enough events (3), and once we have, then have still one more timeout to > check that we don't get more. I tried to follow this suggestion, but one problem occurred. When 'END' key is pressed, more than one 'scroll' events are dispatched. Thus, we cannot assume 3 is a great number for this case. Is there any event like scrollstart?
Assignee | ||
Comment 11•9 years ago
|
||
I think I got the answer. Instead of expecting exactly three events to happen, |more than 3| is more reasonable.
Assignee | ||
Comment 12•9 years ago
|
||
smaug, would you like to review the patch? Thanks.
Attachment #8535795 -
Flags: review?(bugs)
Comment 13•9 years ago
|
||
Comment on attachment 8535795 [details] [diff] [review] Patch 1(v2): Check the result after receiving enough evnets gNumEvents = gNumEvents + 1; Why not just ++gNumEvents;
Attachment #8535795 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 14•9 years ago
|
||
No problem, Thanks!
Assignee | ||
Comment 15•9 years ago
|
||
Carry r+ from smaug. Also, add timeout reason (SimpleTest.requestFlakyTimeout).
Attachment #8534382 -
Attachment is obsolete: true
Attachment #8535795 -
Attachment is obsolete: true
Attachment #8536347 -
Flags: review+
Assignee | ||
Comment 16•9 years ago
|
||
try: https://tbpl.mozilla.org/?tree=Try&rev=4e7d5622fbe7
Assignee | ||
Comment 17•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca218faa12dd
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 20•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ca218faa12dd
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Updated•9 years ago
|
status-b2g-v2.1:
--- → unaffected
status-b2g-v2.2:
--- → fixed
status-firefox35:
--- → unaffected
status-firefox36:
--- → affected
status-firefox37:
--- → fixed
status-firefox-esr31:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•