Closed
Bug 1106732
Opened 10 years ago
Closed 10 years ago
Test failure 'The correct SSL error title is shown - 'Unable to Connect Securely' should equal 'Secure Connection Failed'' in testSecurity/testSSLDisabledErrorPage.js
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)
Tracking
(firefox34 fixed, firefox35 fixed, firefox36 unaffected, firefox37 unaffected)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox34 | --- | fixed |
firefox35 | --- | fixed |
firefox36 | --- | unaffected |
firefox37 | --- | unaffected |
People
(Reporter: teodruta, Assigned: cosmin-malutan)
References
()
Details
(Keywords: regression, Whiteboard: [mozmill-test-failure])
Attachments
(1 file, 2 obsolete files)
1.28 KB,
patch
|
AndreeaMatei
:
review-
|
Details | Diff | Splinter Review |
Module: testSSLDisabledErrorPage
Test: testSecurity/testSSLDisabledErrorPage.js
Failure: 'The correct SSL error title is shown - 'Unable to Connect Securely' should equal 'Secure Connection Failed'
Branches: mozilla-aurora, mozilla-beta
Platforms: All
Locale: All
Report: http://mozmill-daily.blargon7.com/#/remote/report/bdaefa581a1cff14362f7944d610df05
Reproducible on all platforms.
Reporter | ||
Updated•10 years ago
|
status-firefox34:
--- → affected
status-firefox35:
--- → affected
status-firefox36:
--- → unaffected
status-firefox37:
--- → unaffected
Whiteboard: [mozmill-test-failure]
Reporter | ||
Comment 1•10 years ago
|
||
We have multiple failures in this test we should skip this test on beta and aurora.
Added skip patch.
Attachment #8531168 -
Flags: review?(andreea.matei)
Reporter | ||
Comment 2•10 years ago
|
||
Sorry, wrong file.
Attachment #8531168 -
Attachment is obsolete: true
Attachment #8531168 -
Flags: review?(andreea.matei)
Attachment #8531170 -
Flags: review?(andreea.matei)
Reporter | ||
Updated•10 years ago
|
Comment 3•10 years ago
|
||
Comment on attachment 8531170 [details] [diff] [review]
skipssldisablederrorpage.patch
Review of attachment 8531170 [details] [diff] [review]:
-----------------------------------------------------------------
Patch doesn't apply anymore with the other skip, please update. Also the commit message.
Attachment #8531170 -
Flags: review?(andreea.matei) → review-
Reporter | ||
Comment 4•10 years ago
|
||
Fixed rejections.
Attachment #8531170 -
Attachment is obsolete: true
Attachment #8531191 -
Flags: review?(mihaela.velimiroviciu)
Attachment #8531191 -
Flags: review?(andreea.matei)
Comment 5•10 years ago
|
||
Comment on attachment 8531191 [details] [diff] [review]
skipssldisablederrorpage.patch
Review of attachment 8531191 [details] [diff] [review]:
-----------------------------------------------------------------
This has 4 failures, all on OSX. Please see how often it fails, if you can reproduce. We shouldn't skip otherwise or not on all platforms. Just saw the reports now, sorry.
Attachment #8531191 -
Flags: review?(mihaela.velimiroviciu)
Attachment #8531191 -
Flags: review?(andreea.matei)
Attachment #8531191 -
Flags: review-
Comment 6•10 years ago
|
||
(In reply to Teodor Druta from comment #0)
> Branches: mozilla-aurora, mozilla-beta
The status flags do not match those branches. Can you please fix that?
Also please see the other correlated failure here which is:
The SSL error message contains disabled information - 'Firefox cannot guarantee the safety of your data on tlsv1-0.mozqa.com because it uses SSLv3, a broken security protocol.' should contain 'ssl_error_no_cypher_overlap'
Seeing this I do not think it is a bug in our test but somehow the certificate still has SSLv3 enabled? This needs more investigation and totally not a skip patch. We only do that for P1 and partly P2.
Reporter | ||
Updated•10 years ago
|
Reporter | ||
Updated•10 years ago
|
Reporter | ||
Updated•10 years ago
|
Comment 7•10 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #6)
> The SSL error message contains disabled information - 'Firefox cannot
> guarantee the safety of your data on tlsv1-0.mozqa.com because it uses
> SSLv3, a broken security protocol.' should contain
> 'ssl_error_no_cypher_overlap'
>
> Seeing this I do not think it is a bug in our test but somehow the
> certificate still has SSLv3 enabled? This needs more investigation and
> totally not a skip patch. We only do that for P1 and partly P2.
Bug 1096695 changed the message from "An error occurred during a connection to write.skyword.com. Cannot communicate securely with peer: no common encryption algorithm(s). (Error code: ssl_error_no_cypher_overlap)" to "Firefox cannot
> guarantee the safety of your data on tlsv1-0.mozqa.com because it uses
> SSLv3, a broken security protocol.".
We should update the test rather than disabling it.
Comment 8•10 years ago
|
||
Thank you Masatoshi. Given that the mentioned patch landed for 34 and 35, I do not see why the flags have been set wrongly. So I can also only repeat, lets get this fixed. Thanks.
Oh, and given that it is affecting beta and release builds we want to get this fixed sooner than later.
Assignee | ||
Comment 9•10 years ago
|
||
I just checked latest Aurora, Beta and Release
http://mozmill-crowd.blargon7.com/#/remote/report/946d3cd70aaf19c33a8878f8c4b13ea3
http://mozmill-crowd.blargon7.com/#/remote/report/946d3cd70aaf19c33a8878f8c4aee643
http://mozmill-crowd.blargon7.com/#/remote/report/946d3cd70aaf19c33a8878f8c4ade2b9
This bug has been fixed somewhere down the road.
Also this failed only on OSX before and only on en-US. This would come handy, as I checked first on linux until I noticed that and also other locales.
Andreea could you backout the skip?
OS: All → Mac OS X
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(andreea.matei)
Comment 10•10 years ago
|
||
This is not skipped, it failed only a few times on OSX. We can close it then, I think the SSL error message went back.
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(andreea.matei)
Resolution: --- → FIXED
Updated•10 years ago
|
Assignee: nobody → cosmin.malutan
Updated•6 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•