Regression: IndexError on bisecting inbound

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: aaronmt, Assigned: parkouss)

Tracking

({regression})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Using 0.29

Was this inbound build good, bad, or broken? (type 'good', 'bad', 'skip', 'retry', or 'exit' and press Enter): good
12:43.10 LOG: MainThread mozversion INFO application_buildid: 20141102084834
12:43.10 LOG: MainThread mozversion INFO application_changeset: 4af6737ce10b
12:43.10 LOG: MainThread mozversion INFO application_display_name: Nightly
12:43.10 LOG: MainThread mozversion INFO application_id: {aa3c5121-dab2-40e2-81ca-7ea25febc110}
12:43.10 LOG: MainThread mozversion INFO application_name: Fennec
12:43.10 LOG: MainThread mozversion INFO application_remotingname: fennec
12:43.10 LOG: MainThread mozversion INFO application_repository: https://hg.mozilla.org/integration/mozilla-inbound
12:43.10 LOG: MainThread mozversion INFO application_vendor: Mozilla
12:43.10 LOG: MainThread mozversion INFO application_version: 36.0a1
12:43.10 LOG: MainThread mozversion INFO platform_buildid: 20141102084834
12:43.11 LOG: MainThread mozversion INFO platform_changeset: 4af6737ce10b
12:43.11 LOG: MainThread mozversion INFO platform_repository: https://hg.mozilla.org/integration/mozilla-inbound
12:43.11 LOG: MainThread mozversion INFO platform_version: 36.0a1
Traceback (most recent call last):
  File "/Users/AaronMT/Documents/Projects/mozregression/bin/mozregression", line 8, in <module>
    load_entry_point('mozregression==0.29', 'console_scripts', 'mozregression')()
  File "/Users/AaronMT/Documents/Projects/mozregression/mozregression/regression.py", line 453, in cli
    app()
  File "/Users/AaronMT/Documents/Projects/mozregression/mozregression/regression.py", line 451, in <lambda>
    parse_date(options.bad_date))
  File "/Users/AaronMT/Documents/Projects/mozregression/mozregression/regression.py", line 255, in bisect_nightlies
    self.bisect_nightlies(mid_date, bad_date)
  File "/Users/AaronMT/Documents/Projects/mozregression/mozregression/regression.py", line 255, in bisect_nightlies
    self.bisect_nightlies(mid_date, bad_date)
  File "/Users/AaronMT/Documents/Projects/mozregression/mozregression/regression.py", line 224, in bisect_nightlies
    self.bisect_inbound()
  File "/Users/AaronMT/Documents/Projects/mozregression/mozregression/regression.py", line 187, in bisect_inbound
    self.bisect_inbound(revisions_left)
  File "/Users/AaronMT/Documents/Projects/mozregression/mozregression/regression.py", line 187, in bisect_inbound
    self.bisect_inbound(revisions_left)
  File "/Users/AaronMT/Documents/Projects/mozregression/mozregression/regression.py", line 187, in bisect_inbound
    self.bisect_inbound(revisions_left)
  File "/Users/AaronMT/Documents/Projects/mozregression/mozregression/regression.py", line 187, in bisect_inbound
    self.bisect_inbound(revisions_left)
  File "/Users/AaronMT/Documents/Projects/mozregression/mozregression/regression.py", line 187, in bisect_inbound
    self.bisect_inbound(revisions_left)
  File "/Users/AaronMT/Documents/Projects/mozregression/mozregression/regression.py", line 187, in bisect_inbound
    self.bisect_inbound(revisions_left)
  File "/Users/AaronMT/Documents/Projects/mozregression/mozregression/regression.py", line 186, in bisect_inbound
    revisions_left)
  File "/Users/AaronMT/Documents/Projects/mozregression/mozregression/regression.py", line 117, in print_inbound_regression_progress
    revisions_left[0]['revision'],
  File "/Users/AaronMT/Documents/Projects/mozregression/mozregression/inboundfinder.py", line 75, in __getitem__
    return self._cache[i][0]
IndexError: list index out of range
(Assignee)

Comment 1

4 years ago
Created attachment 8531250 [details] [review]
fix crash when printing inbound regression status and there is no revision left

Thanks for pointing this out - it was a corner case when we are trying to write bissection status and there is no more revisions left.
Assignee: nobody → j.parkouss
Attachment #8531250 - Flags: review?(wlachance)
Comment on attachment 8531250 [details] [review]
fix crash when printing inbound regression status and there is no revision left

Looks good, thanks!!
Attachment #8531250 - Flags: review?(wlachance) → review+
Merged PR and released mozregression 0.30.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.