the one-click search header isn't updated immediately when the textfield value changes

VERIFIED FIXED in Firefox 36

Status

()

Firefox
Search
--
minor
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: Dan Wolff, Assigned: florian)

Tracking

35 Branch
Firefox 37
Points:
1
Bug Flags:
firefox-backlog +
qe-verify +

Firefox Tracking Flags

(firefox35 wontfix, firefox36 verified, firefox37 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
I don't use search suggestions.

Steps to reproduce:

1. Search for something, e.g. "xyz" (in order to create search history)
2. Empty the search box
3. Press the down arrow to select a history entry

Actual result:

Notice how the line "Search for xyz with:" updates a split second after the search history entry is selected.

Expected result:

Selecting the search history entry triggers an immediate update to the "Search for xyz with:" line.
(Reporter)

Updated

3 years ago
Blocks: 1088660
(Assignee)

Comment 1

3 years ago
I can't reproduce this; I wonder if it's something that could be happening only on specific or slow hardware.

Florin, could QA check if this bug can be reproduced? Thanks!
Flags: needinfo?(florin.mezei)
Keywords: qawanted
(Assignee)

Comment 2

3 years ago
So, the textfield updates on keydown, but the "Search for xyz with:" header is updated on keyup. "input" is a better event to listen for. Patch coming soon.
Assignee: nobody → florian
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(florin.mezei)
Keywords: qawanted
OS: Linux → All
Hardware: x86 → All
Summary: New search UI updates slowly → the one-click search header isn't updated immediately when the textfield value changes
(Assignee)

Comment 3

3 years ago
Created attachment 8537951 [details] [diff] [review]
Patch
Attachment #8537951 - Flags: review?(felipc)
(Assignee)

Updated

3 years ago
Points: --- → 1
Flags: qe-verify+
Flags: firefox-backlog+
Attachment #8537951 - Flags: review?(felipc) → review+
(Assignee)

Comment 4

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/e0ee525cb903
https://hg.mozilla.org/mozilla-central/rev/e0ee525cb903
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37

Updated

3 years ago
Iteration: --- → 37.2
(Assignee)

Comment 6

3 years ago
Comment on attachment 8537951 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: new search UI
[User impact if declined]: some minor (but perceptible when users type slowly) lag in updating some of the search panel
[Describe test coverage new/current, TBPL]: on central
[Risks and why]: low risk; only changing one event listener.
[String/UUID change made/needed]: none.

I would really like to have this in 36, and it's nice to have for 35 but not absolutely required there (I think the risk is low enough that we should take it though).
Attachment #8537951 - Flags: approval-mozilla-beta?
Attachment #8537951 - Flags: approval-mozilla-aurora?
QA Contact: petruta.rasa
status-firefox35: --- → wontfix
status-firefox36: --- → affected
status-firefox37: --- → fixed
Comment on attachment 8537951 [details] [diff] [review]
Patch

Take it up to Aurora, but at this stage in Beta we shouldn't take on new UI changes.
Attachment #8537951 - Flags: approval-mozilla-beta?
Attachment #8537951 - Flags: approval-mozilla-beta-
Attachment #8537951 - Flags: approval-mozilla-aurora?
Attachment #8537951 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/40962163ae7e
status-firefox36: affected → fixed
Verified as fixed using Developer Edition 36.0a2 and Nightly 37.0a1 2014-01-08 under Ubuntu 12.04 LTS 32-bit, Windows 7 64-bit and Mac OS X 10.9.5
Status: RESOLVED → VERIFIED
status-firefox36: fixed → verified
status-firefox37: fixed → verified
You need to log in before you can comment on or make changes to this bug.