1106902 - After deleting one room, the 'GET /rooms’ method includes the deleted rooms

Status: RESOLVED FIXED

(Hello (Loop) :: Server, defect)

Description

[Maria Angeles Oteo (:oteo)]

Loop server has been changed to report the deleted rooms after a Push notification when the client executes a ‘GET /rooms?version=<version>’ request (where version is the one delivered in the notification).  

This is documented in [1]: "Additionally, if a "?version=<version>" parameter is included, then the list will include the rooms that have been deleted since that version.” 

However, the deleted rooms are not only returned when the version parameter is included, but also when the client executes a ‘GET /rooms’ without the version parameter. E.g. this is received as part of such a request: 

{"roomToken":"VHEB5zvl978","deleted":true},{"roomToken":"iw_LMr6rHI0","deleted":true},{"roomToken":"pdq_mupye78","deleted":true},{"roomToken":"T3Cz1T9Eyas","deleted":true},{"roomToken":"OVyRBE6DL7M","deleted":true}] 

[1] https://wiki.mozilla.org/Loop/Architecture/Rooms

Comment 1

[Maria Angeles Oteo (:oteo)]

Please note that this does not occur in current Development server but on a custom server we have deployed based on current Loop Server master branch.

Comment 2

[Alexis Metaireau (:alexis)]

I suspect you are expecting to not have these included, correct? If so, we'll make this happen ;)

Comment 3

[Maria Angeles Oteo (:oteo)]

(In reply to Alexis Metaireau (:alexis) from comment #2)
> I suspect you are expecting to not have these included, correct? If so,
> we'll make this happen ;)

Very correct, Thanks a lot Alexis!

Comment 4

[Mathieu Leplatre [:leplatrem]]

Attachment: https://github.com/mozilla-services/loop-server/pull/269

Comment 5

[Rémy Hubscher (:natim)]

https://github.com/mozilla-services/loop-server/commit/ff80feaa572e0f02352d6dfbae6ade81e2a4b3a1