1106991 - Firefox Hello cog/gear sub-menu "Tour" entry is missing an icon

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot

STR:
 1. Open Firefox Hello menu.
    (If all you see is "Getting started", click that, & re-open the menu)

 2. Click the Cog/Gear icon in the bottom-right.

 3. Look at the Cog/Gear icon's sub-menu entries.

ACTUAL RESULTS: The bottom two entries (Sign In, Help) have icons next to them; the top entry (Tour) does not.  Moreover, it's aligned above the icons for the entries below it, which looks pretty broken.

EXPECTED RESULTS: Top icon should probably have an icon (or at least, it shouldn't have its text aligned with the icons for the entries below it).

Screenshot attached.

Version info: Nightly 37.0a1 (2014-12-02)
Mozilla/5.0 (X11; Linux x86_64; rv:37.0) Gecko/20100101 Firefox/37.0
Ubuntu 14.10

Comment 1

[Maire Reavy [:mreavy]]

Jared, Mark -- Is this being fixed on another bug?

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

No, this is not being worked on in another bug, however there is a needinfo request open at https://bugzilla.mozilla.org/show_bug.cgi?id=1074932#c10 for the icon. Maire, if you can follow up with Michael that will help.

Comment 3

[:shell escalante]

Hi UX guys, please see jared's comment 2, need asset for icon please

Comment 4

[Sevaan Franks [:sevaan]]

Leaving this for mmaslaney.

Comment 5

[Maire Reavy [:mreavy]]

Mike -- We really need this icon ASAP since we want to fix this in Fx35.  Can we get it by this Wednesday (10th of Dec)?

Comment 6

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: FX_Hello-glyph-tour-16x16.svg

Tour Icon attached

Comment 7

[Romain Gauthier [:tOkeshu]]

Attachment: Add the tour icon

Comment 8

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8534344 [details] [diff] [review]
Add the tour icon

Review of attachment 8534344 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, though could you please add an entry to the UI showcase? :)

Comment 9

[Maire Reavy [:mreavy]]

(In reply to Nicolas Perriault (:NiKo`) — needinfo me if you need my attention from comment #8)
> 
> Looks good, though could you please add an entry to the UI showcase? :)

Romain -- Do you think you can add this to the patch and get it back up for review today?

Comment 10

[Maire Reavy [:mreavy]]

Comment on attachment 8534344 [details] [diff] [review]
Add the tour icon

Review of attachment 8534344 [details] [diff] [review]:
-----------------------------------------------------------------

Just clearing the review since Niko wants to see the patch again with an entry to the UI showcase

Comment 11

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8534344 [details] [diff] [review]
Add the tour icon

Review of attachment 8534344 [details] [diff] [review]:
-----------------------------------------------------------------

Just clarified with :tOkeshu over IRC, the icon was already listed in the UI showcase but the icon missing; this is now fixed. Hence r+ :)

Comment 12

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

https://hg.mozilla.org/integration/fx-team/rev/63205db3303e

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/63205db3303e

Comment 14

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8534344 [details] [diff] [review]
Add the tour icon

Approval Request Comment
[Feature/regressing bug #]: UITour for loop/hello

[User impact if declined]: Ugly menu

[Describe test coverage new/current, TBPL]: on m-c momentarily

[Risks and why]: very low risk; just adds an icon to a menu item where the others have icons.  Not nominating for Beta until the UI tour code is uplifted there (another dev is writing that uplift request).

[String/UUID change made/needed]: none.

Comment 15

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8534344 [details] [diff] [review]
Add the tour icon

Approval Request Comment
[Feature/regressing bug #]: UITour

[User impact if declined]: Odd missing icon in sub-menu

[Describe test coverage new/current, TBPL]: manual

[Risks and why]: Almost no risk. Turns out the "Tour" menu entry is already on Beta; the item I thought this was blocked on was the first-time-experience patches; I should have asked for beta approval with the rest of this batch. 

[String/UUID change made/needed]: none

Comment 16

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/205354ee00bb

Comment 17

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-beta/rev/81e0c927cdec