Closed Bug 1106991 Opened 10 years ago Closed 10 years ago

Firefox Hello cog/gear sub-menu "Tour" entry is missing an icon

Categories

(Hello (Loop) :: Client, defect, P1)

x86_64
Linux
defect
Points:
1

Tracking

(firefox35 fixed, firefox36 fixed, firefox37 fixed)

RESOLVED FIXED
mozilla37
Iteration:
37.1
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
firefox37 --- fixed
backlog Fx35+

People

(Reporter: dholbert, Assigned: rgauthier)

Details

Attachments

(3 files)

Attached image screenshot
STR:
 1. Open Firefox Hello menu.
    (If all you see is "Getting started", click that, & re-open the menu)

 2. Click the Cog/Gear icon in the bottom-right.

 3. Look at the Cog/Gear icon's sub-menu entries.

ACTUAL RESULTS: The bottom two entries (Sign In, Help) have icons next to them; the top entry (Tour) does not.  Moreover, it's aligned above the icons for the entries below it, which looks pretty broken.

EXPECTED RESULTS: Top icon should probably have an icon (or at least, it shouldn't have its text aligned with the icons for the entries below it).

Screenshot attached.

Version info: Nightly 37.0a1 (2014-12-02)
Mozilla/5.0 (X11; Linux x86_64; rv:37.0) Gecko/20100101 Firefox/37.0
Ubuntu 14.10
Jared, Mark -- Is this being fixed on another bug?
backlog: --- → Fx35+
Flags: needinfo?(standard8)
Flags: needinfo?(jaws)
Priority: -- → P1
No, this is not being worked on in another bug, however there is a needinfo request open at https://bugzilla.mozilla.org/show_bug.cgi?id=1074932#c10 for the icon. Maire, if you can follow up with Michael that will help.
Flags: needinfo?(standard8)
Flags: needinfo?(mreavy)
Flags: needinfo?(jaws)
Hi UX guys, please see jared's comment 2, need asset for icon please
Flags: needinfo?(sfranks)
Flags: needinfo?(mmaslaney)
Leaving this for mmaslaney.
Flags: needinfo?(sfranks)
Mike -- We really need this icon ASAP since we want to fix this in Fx35.  Can we get it by this Wednesday (10th of Dec)?
Flags: needinfo?(mreavy)
Tour Icon attached
Flags: needinfo?(mmaslaney)
Assignee: nobody → rgauthier
Attachment #8534344 - Flags: review?(nperriault)
Comment on attachment 8534344 [details] [diff] [review]
Add the tour icon

Review of attachment 8534344 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, though could you please add an entry to the UI showcase? :)
(In reply to Nicolas Perriault (:NiKo`) — needinfo me if you need my attention from comment #8)
> 
> Looks good, though could you please add an entry to the UI showcase? :)

Romain -- Do you think you can add this to the patch and get it back up for review today?
Flags: needinfo?(rgauthier)
Comment on attachment 8534344 [details] [diff] [review]
Add the tour icon

Review of attachment 8534344 [details] [diff] [review]:
-----------------------------------------------------------------

Just clearing the review since Niko wants to see the patch again with an entry to the UI showcase
Attachment #8534344 - Flags: review?(nperriault)
Comment on attachment 8534344 [details] [diff] [review]
Add the tour icon

Review of attachment 8534344 [details] [diff] [review]:
-----------------------------------------------------------------

Just clarified with :tOkeshu over IRC, the icon was already listed in the UI showcase but the icon missing; this is now fixed. Hence r+ :)
Attachment #8534344 - Flags: review+
https://hg.mozilla.org/integration/fx-team/rev/63205db3303e
Iteration: --- → 37.1
Points: --- → 1
Target Milestone: --- → mozilla37
Flags: needinfo?(rgauthier)
Comment on attachment 8534344 [details] [diff] [review]
Add the tour icon

Approval Request Comment
[Feature/regressing bug #]: UITour for loop/hello

[User impact if declined]: Ugly menu

[Describe test coverage new/current, TBPL]: on m-c momentarily

[Risks and why]: very low risk; just adds an icon to a menu item where the others have icons.  Not nominating for Beta until the UI tour code is uplifted there (another dev is writing that uplift request).

[String/UUID change made/needed]: none.
Attachment #8534344 - Flags: approval-mozilla-aurora?
Attachment #8534344 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8534344 [details] [diff] [review]
Add the tour icon

Approval Request Comment
[Feature/regressing bug #]: UITour

[User impact if declined]: Odd missing icon in sub-menu

[Describe test coverage new/current, TBPL]: manual

[Risks and why]: Almost no risk. Turns out the "Tour" menu entry is already on Beta; the item I thought this was blocked on was the first-time-experience patches; I should have asked for beta approval with the rest of this batch. 

[String/UUID change made/needed]: none
Attachment #8534344 - Flags: approval-mozilla-beta?
Attachment #8534344 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: