Closed
Bug 1107013
Opened 11 years ago
Closed 11 years ago
Local Browser Toolbox builds don't clear startup cache
Categories
(DevTools :: Framework, defect)
DevTools
Framework
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 37
People
(Reporter: jryans, Assigned: jryans)
Details
Attachments
(1 file, 1 obsolete file)
If you do an incremental build of the browser to work on changes to the Browser Toolbox itself, the changes may not appear. Only a full rebuild makes them apply.
This occurs because the child profile's startup cache is outdated, so we need to explicitly clear it in this case.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #8531535 -
Flags: review?(bgrinstead)
Assignee | ||
Comment 3•11 years ago
|
||
/r/1135 - Bug 1107013 - Clear Browser Toolbox cache for local builds. r=bgrins
Pull down this commit:
hg pull review -r b4983f053cee1a3b284603e8853cf02a0dc29942
Updated•11 years ago
|
Attachment #8531535 -
Flags: review?(bgrinstead) → review+
Comment 4•11 years ago
|
||
https://reviewboard.mozilla.org/r/1133/#review685
::: browser/devtools/framework/ToolboxProcess.jsm
(Diff revision 1)
> + Services.appinfo.defaultUpdateChannel == "default") {
As discussed, I think the defaultUpdateChannel check here is covering a case that we probably don't need to worry about, so could be removed (and comment updated) to simplify the condition
Sounds great since it seems it will fix the mysterious problems I've been seeing with the BT not reflecting built changes
Assignee | ||
Comment 5•11 years ago
|
||
https://reviewboard.mozilla.org/r/1133/#review697
> As discussed, I think the defaultUpdateChannel check here is covering a case that we probably don't need to worry about, so could be removed (and comment updated) to simplify the condition
Okay, I've made this change.
Assignee | ||
Comment 6•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Assignee | ||
Comment 8•10 years ago
|
||
Attachment #8531535 -
Attachment is obsolete: true
Attachment #8618776 -
Flags: review+
Assignee | ||
Comment 9•10 years ago
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•