Local Browser Toolbox builds don't clear startup cache

RESOLVED FIXED in Firefox 37

Status

DevTools
Framework
RESOLVED FIXED
4 years ago
6 days ago

People

(Reporter: jryans, Assigned: jryans)

Tracking

Trunk
Firefox 37

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

If you do an incremental build of the browser to work on changes to the Browser Toolbox itself, the changes may not appear.  Only a full rebuild makes them apply.

This occurs because the child profile's startup cache is outdated, so we need to explicitly clear it in this case.
(Assignee)

Comment 2

4 years ago
Created attachment 8531535 [details]
MozReview Request: bz://1107013/jryans
Attachment #8531535 - Flags: review?(bgrinstead)
(Assignee)

Comment 3

4 years ago
/r/1135 - Bug 1107013 - Clear Browser Toolbox cache for local builds. r=bgrins

Pull down this commit:

hg pull review -r b4983f053cee1a3b284603e8853cf02a0dc29942
Attachment #8531535 - Flags: review?(bgrinstead) → review+
https://reviewboard.mozilla.org/r/1133/#review685

::: browser/devtools/framework/ToolboxProcess.jsm
(Diff revision 1)
> +        Services.appinfo.defaultUpdateChannel == "default") {

As discussed, I think the defaultUpdateChannel check here is covering a case that we probably don't need to worry about, so could be removed (and comment updated) to simplify the condition

Sounds great since it seems it will fix the mysterious problems I've been seeing with the BT not reflecting built changes
(Assignee)

Comment 5

4 years ago
https://reviewboard.mozilla.org/r/1133/#review697

> As discussed, I think the defaultUpdateChannel check here is covering a case that we probably don't need to worry about, so could be removed (and comment updated) to simplify the condition

Okay, I've made this change.
https://hg.mozilla.org/mozilla-central/rev/9832a29c55e9
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
(Assignee)

Comment 8

3 years ago
Comment on attachment 8531535 [details]
MozReview Request: bz://1107013/jryans
Attachment #8531535 - Attachment is obsolete: true
Attachment #8618776 - Flags: review+
(Assignee)

Comment 9

3 years ago
Created attachment 8618776 [details]
MozReview Request: Bug 1107013 - Clear Browser Toolbox cache for local builds. r=bgrins

Updated

6 days ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.