Closed Bug 1107013 Opened 8 years ago Closed 8 years ago

Local Browser Toolbox builds don't clear startup cache

Categories

(DevTools :: Framework, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 37

People

(Reporter: jryans, Assigned: jryans)

Details

Attachments

(1 file, 1 obsolete file)

If you do an incremental build of the browser to work on changes to the Browser Toolbox itself, the changes may not appear.  Only a full rebuild makes them apply.

This occurs because the child profile's startup cache is outdated, so we need to explicitly clear it in this case.
/r/1135 - Bug 1107013 - Clear Browser Toolbox cache for local builds. r=bgrins

Pull down this commit:

hg pull review -r b4983f053cee1a3b284603e8853cf02a0dc29942
Attachment #8531535 - Flags: review?(bgrinstead) → review+
https://reviewboard.mozilla.org/r/1133/#review685

::: browser/devtools/framework/ToolboxProcess.jsm
(Diff revision 1)
> +        Services.appinfo.defaultUpdateChannel == "default") {

As discussed, I think the defaultUpdateChannel check here is covering a case that we probably don't need to worry about, so could be removed (and comment updated) to simplify the condition

Sounds great since it seems it will fix the mysterious problems I've been seeing with the BT not reflecting built changes
https://reviewboard.mozilla.org/r/1133/#review697

> As discussed, I think the defaultUpdateChannel check here is covering a case that we probably don't need to worry about, so could be removed (and comment updated) to simplify the condition

Okay, I've made this change.
https://hg.mozilla.org/mozilla-central/rev/9832a29c55e9
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Attachment #8531535 - Attachment is obsolete: true
Attachment #8618776 - Flags: review+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.