[Settings][WiFi] WiFi signal indicators in settings do not dynamically update

RESOLVED FIXED in 2.2 S2 (19dec)

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jlee, Assigned: mancas)

Tracking

unspecified
2.2 S2 (19dec)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:2.2+, b2g-v2.0 affected, b2g-v2.1 affected, b2g-v2.2 fixed)

Details

(Whiteboard: [2.2-flame-reduced-run], )

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
arthurcc
: review+
arthurcc
: feedback+
Details | Review
Description:
When moving away from wireless signal, the signal strength indicators in WiFi settings do not reflect the signal strength fluctuations.
   
   
Repro Steps:

Prerequisites: *WiFi turned ON  *WiFi networks available  *Launch Settings

1) Update a Flame device to BuildID: 20141203040207
2) Open WiFi settings
3) Check available networks list
4) Connect to a network and than move away from the wireless signal source
5) View WiFI indicators in Settings while moving away from wireless signal source
  
Actual:
WiFi signal indicators in Settings do not dynamically update. When moving away from signal, the indicators will not change. Indicators do not change after tapping "Search Again".
  
Expected: 
WiFi signal indicators in Settings do dynamically update. When moving away from signal, the indicators will change. Signal strength indicators change/update after tapping "Search Again".
  
Environmental Variables:
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141203040207
Gaia: 725685831f5336cf007e36d9a812aad689604695
Gecko: 2c9781c3e9b5
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
  
  
Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/4175/
See attached: video clip (http://youtu.be/Le_5fjTgbpY), logcat (Note: Cannot get logcat due to steps)
Issue occurs in Flame 2.0 and Flame 2.1.

WiFi signal indicators in Settings do not dynamically update. When moving away from signal, the indicators will not change. Indicators do not change after tapping "Search Again".

Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141202001201
Gaia: ccb49abe412c978a4045f0c75abff534372716c4
Gecko: 18fb67530b22
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.0 (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141202000201
Gaia: 8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko: c756bd8bf3c3
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 32.0 (2.0)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(dharris)
Wifi Icon in both the status bar, and in settings menu do not update dynamically to inform the user of the wifi strength. Basic wifi indicator is broken. Nominating to block 2.2
blocking-b2g: --- → 2.2?
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(dharris) → needinfo?(gchang)
This bug also occurs in the FTE/FTU for Flame 2.2 Master (319mb)(KitKat)(Full Flash)

Link to Failed Test Case:
2338 - Verify Select network signal strength icon
https://moztrap.mozilla.org/manage/case/2338/
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(dharris)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(dharris)
NI developer for this.
Hi Vincent, 
Not sure who is the right wifi owner, might need your help to dispatch this.
Flags: needinfo?(gchang) → needinfo?(vchang)
Hi Arthur, I don't observe getNetworks or getKnownNetworks APIs been called in gecko. Can you help to check it?
Flags: needinfo?(vchang)
Flags: needinfo?(arthur.chen)
We call to getKnownNetworks only when scanning. When signal strength changes, does gaia get notified via the status change event?
Flags: needinfo?(arthur.chen) → needinfo?(vchang)
The signal strength change is reported via connectioninfoupdate event for connected AP which works fine. But I think this bug is related to "Not updated AP lists dynamically" when moving.
Flags: needinfo?(vchang)
From the description, it is about WiFi signal strength indicators. At least we should fix the signal strength indicator of the connected AP. Depending on resources, we can then fix the ones of the other APs.
Assignee: nobody → b.mcb
Posted file Proposed patch
Arthur, could you take a look at this first approach when you get a chance?

With the current resources, I think we can only update the current connected network, but I'm not an expert of the WifiManager api so, if I'm wrong, please tell me.

After your review, if everything its ok, I will add unit tests to cover this case.

Thanks!
Attachment #8536500 - Flags: feedback?(arthur.chen)
Adding myself and Sam to the loop, as FTU is also affected (kudos Manuel for the heads up).

It would be nice to have the same on FTU, but not a priority for me, as is nog highly probable that the user plays with the app while on the move.
Comment on attachment 8536500 [details] [review]
Proposed patch

Looks good! f=me, thanks.
Attachment #8536500 - Flags: feedback?(arthur.chen) → feedback+
Comment on attachment 8536500 [details] [review]
Proposed patch

Hey Arthur, could you review the final version of the patch with the unit tests?

Thanks!
Attachment #8536500 - Flags: review?(arthur.chen)
Comment on attachment 8536500 [details] [review]
Proposed patch

r=me, thanks for the work!
Attachment #8536500 - Flags: review?(arthur.chen) → review+
Triage: blocking.
blocking-b2g: 2.2? → 2.2+
Do we need to fix this in branch 2.0 and 2.1?
Keywords: checkin-needed
We need approval for uplifting to 2.1 and 2.0. I think we can leave it until the bug is considered critical and approved.
Master: https://github.com/mozilla-b2g/gaia/commit/055b14ea1a97ac4f3cf7e996ae06919ca750b21c
Status: NEW → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S2 (19dec)
Verification is failed due the following issues.

1. WiFi signal indicator in Settings dynamically updates, when moving away from signal,but after tapping "Search Again", the signal icon shows the whole signal bar for a couple seconds.
2. When the device is out of range WiFi signal, the WiFi bar still shows a low signal and never update it

"Flame 2.2

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141222040204
Gaia: ca6e91e09ef3ab417a0f6b6d6668d43597d85700
Gecko: b915a50bc6be
Gonk: e5c6b275d77ca95fb0f2051c3d2242e6e0d0e442
Version: 37.0a1 (2.2)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0"
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?][failed-verification]
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?][failed-verification] → [QAnalyst-Triage+][failed-verification]
Flags: needinfo?(ktucker)
You need to log in before you can comment on or make changes to this bug.