1107136 - Add a keyboard shortcut for Unpin-all

Status: VERIFIED FIXED

(Tree Management :: Treeherder, enhancement, P4)

Description

[Jonathan French (:jfrench)]

It seems with all the new shortcut functionality we've been adding in bug 1030686 and elsewhere, the only thing missing from being able to operate completely mouse free while returning to a 'default' platform state, is a shortcut for un-pin all.

I pose a two-key-modifier since the action is 'destructive'. Perhaps: 

Ctrl+Shift+u
...since "u" maps mentally to un-pin
...we do use u for showing 'unstarred' failures however

Ctrl+Shift+spacebar (since spacebar is the pinning action)

We can't use just Ctrl+u since it is native browser view-source, and we want to keep native browser pagination via the spacebar.

Or whatever other key and modifier combination you guys prefer. If there's agreement I'll assign myself and have a look at it.

Comment 1

[Jonathan French (:jfrench)]

Adding a few of the folks above, for feedback/consensus.

Comment 2

[Phil Ringnalda (:philor)]

Doesn't matter to me, I've never used unpin all or seen the reason for it.

Comment 3

[Jonathan French (:jfrench)]

That's good to know, thanks Phil.

Comment 4

[David Burns :automatedtester]

I think the sheriffs would be able to answer this better than me

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I think it'd be nice to have for completeness' sake, especially if we want non-mouse accessibility, but I, too, rarely use it, so don't really care what the shortcut ends up being, as long as it isn't easily triggered accidentally.

Comment 6

[Ed Morley [:emorley]]

I'm with Wes's comment :-)

Comment 7

[Jonathan French (:jfrench)]

Ok, thanks guys. Once the other three shortcuts I've done have landed I'll do unpin.

Comment 8

[Jonathan French (:jfrench)]

A note for myself; I think we might want to also clear the classification comments field on an Unpin-all, returning the pinboard to a default state.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Jonathan French (:jfrench) from comment #8)
> A note for myself; I think we might want to also clear the classification
> comments field on an Unpin-all, returning the pinboard to a default state.

That's bug 1101760.

Comment 10

[Jonathan French (:jfrench)]

Sounds good, I've just assigned myself that bug also.

Comment 11

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#319

Please see above PR for review and status.

Comment 12

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/57c7a28fd3d48d2c433ef8dd23a0b3d3cf490d35
Bug 1107136 -  Add a keyboard shortcut for clear-all in pinboard

https://github.com/mozilla/treeherder-ui/commit/8c8ecd83c23831c9fe3a0d198fd1d8ce0e4031af
Merge pull request #319 from tojonmz/clear-pinboard-shortcut

Bug 1107136 -  Add a keyboard shortcut for clear-all in pinboard

Comment 13

[Jonathan French (:jfrench)]

Marking fixed per the above merge. I will verify after push to stage/prod.

Comment 14

[Jonathan French (:jfrench)]

Verified fixed on stage.

Comment 15

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/5c433b0e445de9827c2f5af3d09a646c900ed84c
Bug 1107136 -  Add a keyboard shortcut for clear-all in pinboard

https://github.com/mozilla/treeherder/commit/bb6705f2222892ed071287cef3da676f5fc211dc
Merge pull request #319 from tojonmz/clear-pinboard-shortcut

Bug 1107136 -  Add a keyboard shortcut for clear-all in pinboard