Add a keyboard shortcut for Unpin-all

VERIFIED FIXED

Status

P4
enhancement
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: jfrench, Assigned: jfrench)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
It seems with all the new shortcut functionality we've been adding in bug 1030686 and elsewhere, the only thing missing from being able to operate completely mouse free while returning to a 'default' platform state, is a shortcut for un-pin all.

I pose a two-key-modifier since the action is 'destructive'. Perhaps: 

Ctrl+Shift+u
...since "u" maps mentally to un-pin
...we do use u for showing 'unstarred' failures however

Ctrl+Shift+spacebar (since spacebar is the pinning action)

We can't use just Ctrl+u since it is native browser view-source, and we want to keep native browser pagination via the spacebar.

Or whatever other key and modifier combination you guys prefer. If there's agreement I'll assign myself and have a look at it.
(Assignee)

Updated

4 years ago
Flags: needinfo?(philringnalda)
Flags: needinfo?(kwierso)
Flags: needinfo?(emorley)
Flags: needinfo?(dburns)
(Assignee)

Comment 1

4 years ago
Adding a few of the folks above, for feedback/consensus.
Doesn't matter to me, I've never used unpin all or seen the reason for it.
Flags: needinfo?(philringnalda)
(Assignee)

Comment 3

4 years ago
That's good to know, thanks Phil.
I think the sheriffs would be able to answer this better than me
Flags: needinfo?(dburns)
I think it'd be nice to have for completeness' sake, especially if we want non-mouse accessibility, but I, too, rarely use it, so don't really care what the shortcut ends up being, as long as it isn't easily triggered accidentally.
Flags: needinfo?(kwierso)

Comment 6

4 years ago
I'm with Wes's comment :-)
Flags: needinfo?(emorley)
(Assignee)

Comment 7

4 years ago
Ok, thanks guys. Once the other three shortcuts I've done have landed I'll do unpin.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
(Assignee)

Comment 8

4 years ago
A note for myself; I think we might want to also clear the classification comments field on an Unpin-all, returning the pinboard to a default state.
(In reply to Jonathan French (:jfrench) from comment #8)
> A note for myself; I think we might want to also clear the classification
> comments field on an Unpin-all, returning the pinboard to a default state.

That's bug 1101760.
(Assignee)

Comment 10

4 years ago
Sounds good, I've just assigned myself that bug also.
(Assignee)

Comment 11

4 years ago
Created attachment 8542212 [details] [review]
treeherder-ui-PR#319

Please see above PR for review and status.
Attachment #8542212 - Flags: review?(cdawson)

Comment 12

4 years ago
Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/57c7a28fd3d48d2c433ef8dd23a0b3d3cf490d35
Bug 1107136 -  Add a keyboard shortcut for clear-all in pinboard

https://github.com/mozilla/treeherder-ui/commit/8c8ecd83c23831c9fe3a0d198fd1d8ce0e4031af
Merge pull request #319 from tojonmz/clear-pinboard-shortcut

Bug 1107136 -  Add a keyboard shortcut for clear-all in pinboard

Updated

4 years ago
Attachment #8542212 - Flags: review?(cdawson) → review+
(Assignee)

Comment 13

4 years ago
Marking fixed per the above merge. I will verify after push to stage/prod.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Comment 14

4 years ago
Verified fixed on stage.
Status: RESOLVED → VERIFIED

Comment 15

4 years ago
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/5c433b0e445de9827c2f5af3d09a646c900ed84c
Bug 1107136 -  Add a keyboard shortcut for clear-all in pinboard

https://github.com/mozilla/treeherder/commit/bb6705f2222892ed071287cef3da676f5fc211dc
Merge pull request #319 from tojonmz/clear-pinboard-shortcut

Bug 1107136 -  Add a keyboard shortcut for clear-all in pinboard
You need to log in before you can comment on or make changes to this bug.