It seems with all the new shortcut functionality we've been adding in bug 1030686 and elsewhere, the only thing missing from being able to operate completely mouse free while returning to a 'default' platform state, is a shortcut for un-pin all. I pose a two-key-modifier since the action is 'destructive'. Perhaps: Ctrl+Shift+u ...since "u" maps mentally to un-pin ...we do use u for showing 'unstarred' failures however Ctrl+Shift+spacebar (since spacebar is the pinning action) We can't use just Ctrl+u since it is native browser view-source, and we want to keep native browser pagination via the spacebar. Or whatever other key and modifier combination you guys prefer. If there's agreement I'll assign myself and have a look at it.
Adding a few of the folks above, for feedback/consensus.
Doesn't matter to me, I've never used unpin all or seen the reason for it.
That's good to know, thanks Phil.
I think the sheriffs would be able to answer this better than me
I think it'd be nice to have for completeness' sake, especially if we want non-mouse accessibility, but I, too, rarely use it, so don't really care what the shortcut ends up being, as long as it isn't easily triggered accidentally.
I'm with Wes's comment :-)
Ok, thanks guys. Once the other three shortcuts I've done have landed I'll do unpin.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
A note for myself; I think we might want to also clear the classification comments field on an Unpin-all, returning the pinboard to a default state.
(In reply to Jonathan French (:jfrench) from comment #8) > A note for myself; I think we might want to also clear the classification > comments field on an Unpin-all, returning the pinboard to a default state. That's bug 1101760.
Sounds good, I've just assigned myself that bug also.
Created attachment 8542212 [details] [review] treeherder-ui-PR#319 Please see above PR for review and status.
Attachment #8542212 - Flags: review?(cdawson)
Commits pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/57c7a28fd3d48d2c433ef8dd23a0b3d3cf490d35 Bug 1107136 - Add a keyboard shortcut for clear-all in pinboard https://github.com/mozilla/treeherder-ui/commit/8c8ecd83c23831c9fe3a0d198fd1d8ce0e4031af Merge pull request #319 from tojonmz/clear-pinboard-shortcut Bug 1107136 - Add a keyboard shortcut for clear-all in pinboard
Attachment #8542212 - Flags: review?(cdawson) → review+
Marking fixed per the above merge. I will verify after push to stage/prod.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Verified fixed on stage.
Status: RESOLVED → VERIFIED
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/5c433b0e445de9827c2f5af3d09a646c900ed84c Bug 1107136 - Add a keyboard shortcut for clear-all in pinboard https://github.com/mozilla/treeherder/commit/bb6705f2222892ed071287cef3da676f5fc211dc Merge pull request #319 from tojonmz/clear-pinboard-shortcut Bug 1107136 - Add a keyboard shortcut for clear-all in pinboard
You need to log in before you can comment on or make changes to this bug.