Closed Bug 1107200 Opened 9 years ago Closed 9 years ago

[Calendar] can't add a new account after removing an account

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

defect
Not set
normal

Tracking

(b2g-v2.0 unaffected, b2g-v2.1 unaffected, b2g-v2.2 verified)

VERIFIED FIXED
Tracking Status
b2g-v2.0 --- unaffected
b2g-v2.1 --- unaffected
b2g-v2.2 --- verified

People

(Reporter: mmedeiros, Assigned: mmedeiros)

References

Details

Attachments

(2 files)

      No description provided.
this is a regression introduced by the accessibility patch.

need to make sure we remove the `.remove-dialog` class when showing the view.
Summary: [Calendar] cant → [Calendar] can't add a new account after removing an account
Assignee: nobody → mmedeiros
Status: NEW → ASSIGNED
this fixes the regression. marking :yzen as the reviewer since he did the original a11y work and :gaye is away for the next couple weeks.
Attachment #8531722 - Flags: review?(yzenevich)
Comment on attachment 8531722 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26611

Looks and works well. Just one comment in Github for me to understand the case better. Thanks for catching it and sorry for the regression.
Attachment #8531722 - Flags: review?(yzenevich) → review+
landed on master: https://github.com/mozilla-b2g/gaia/commit/f3d9a29852cde945f800b0568437a74bf1ecc4ce
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Attached video verified_v2.2.3gp
This bug has been verified as "pass" on latest build of Flame v2.2.

STR:
1.Launch Calendar app.
2.Tap the menu button at top left corner.
3.Tap the "Settings" button.
4.Tap the "Add Account" button.
5.Log in an account.
6.Tap the save button.
7.Repeat step 2,3.
8.Click the account we loged in.
9.Tap the "Remove local data" button.
10.Tap the "Confirm" button.
11.Log in another account.
Actual result: User can add a new account after removing an account.
See attachment:verified_v2.2.3gp

Device: Flame 2.2 build(pass)
Build ID               20150630162500
Gaia Revision          bd386f346eb1591fddbc84bf034b22700e7e2a58
Gaia Date              2015-06-30 15:53:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f16c1125b9d6
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150630.200238
Firmware Date          Tue Jun 30 20:02:49 EDT 2015
Bootloader             L1TC000118D0
Status: RESOLVED → VERIFIED
QA Whiteboard: [MGSEI-Triage+]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: