Remove mockMozNotification

RESOLVED FIXED

Status

Firefox OS
Gaia::System
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gandalf, Assigned: gandalf)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
lightsofapollo
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
Once we fix bug 1095109 we can get rid of shared/test/integration/mock_navigator_moz_notification.js
(Assignee)

Updated

3 years ago
Depends on: 1095109

Updated

3 years ago
Component: Gaia::UI Tests → Gaia::System
(Assignee)

Comment 1

3 years ago
Created attachment 8532057 [details] [review]
pull request

As a follow up to bug 1095109, we can now safely remove mockMozNotification.

Gaye, you wrote that mock. Can your review my patch?
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Attachment #8532057 - Flags: review?(gaye)
(In reply to Zibi Braniecki [:gandalf] from comment #1)
> Created attachment 8532057 [details] [review]
> pull request
> 
> As a follow up to bug 1095109, we can now safely remove mockMozNotification.
> 
> Gaye, you wrote that mock. Can your review my patch?

Hey just had a baby and won't be working for a few weeks sorry! Ask :lightsofapollo?
Flags: needinfo?(jlal)
Attachment #8532057 - Flags: review?(gaye)
(Assignee)

Comment 3

3 years ago
Comment on attachment 8532057 [details] [review]
pull request

Congratulations! :)
Attachment #8532057 - Flags: review?(jlal)
Comment on attachment 8532057 [details] [review]
pull request

r+
Flags: needinfo?(jlal)
Attachment #8532057 - Flags: review?(jlal) → review+
(Assignee)

Comment 5

3 years ago
Commit: https://github.com/zbraniecki/gaia/commit/2828ea539a7bd98e7efb53f3978870714b319946
Merge: https://github.com/mozilla-b2g/gaia/commit/a53a3a1d5d4f8d758d5f00684d7dbb76d5cb5da1
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.