1107232 - Remove mockMozNotification

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Once we fix bug 1095109 we can get rid of shared/test/integration/mock_navigator_moz_notification.js

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: pull request

As a follow up to bug 1095109, we can now safely remove mockMozNotification.

Gaye, you wrote that mock. Can your review my patch?

Comment 2

[Gareth Aye [:gaye] (back from PTO)]

(In reply to Zibi Braniecki [:gandalf] from comment #1)
> Created attachment 8532057 [details] [review]
> pull request
> 
> As a follow up to bug 1095109, we can now safely remove mockMozNotification.
> 
> Gaye, you wrote that mock. Can your review my patch?

Hey just had a baby and won't be working for a few weeks sorry! Ask :lightsofapollo?

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8532057 [details] [review]
pull request

Congratulations! :)

Comment 4

[James Lal [:lightsofapollo]]

Comment on attachment 8532057 [details] [review]
pull request

r+

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/zbraniecki/gaia/commit/2828ea539a7bd98e7efb53f3978870714b319946
Merge: https://github.com/mozilla-b2g/gaia/commit/a53a3a1d5d4f8d758d5f00684d7dbb76d5cb5da1