Closed
Bug 1107340
Opened 11 years ago
Closed 10 years ago
Document xsendfile_header parameter
Categories
(Bugzilla :: Documentation, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 6.0
People
(Reporter: gerv, Assigned: gerv)
References
Details
Attachments
(1 file)
2.91 KB,
patch
|
mcote
:
review+
|
Details | Diff | Splinter Review |
This parameter has no documentation. It needs an entry here:
http://bugzilla.readthedocs.org/en/latest/administering/parameters.html
Gerv
Assignee | ||
Comment 1•11 years ago
|
||
![]() |
||
Comment 2•11 years ago
|
||
Comment on attachment 8532293 [details] [diff] [review]
Patch v.1
I know nothing about this feature, and Bonsai is unable to find the original bug because all the recent history of Bugzilla has been destroyed with your big doc merge. So no idea who reviewed the original code.
Attachment #8532293 -
Flags: review?(LpSolit) → review?
![]() |
||
Comment 3•11 years ago
|
||
(In reply to Frédéric Buclin from comment #2)
> all the recent history of Bugzilla has been destroyed
And by recent, I mean all commits for the last 5 months! Both CVS and bzr history are unusable.
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 8532293 [details] [diff] [review]
Patch v.1
This text comes pretty much straight from the documentation of the parameter in the Parameters UI.
Gerv
Attachment #8532293 -
Flags: review? → review?(dkl)
Assignee | ||
Updated•11 years ago
|
Attachment #8532293 -
Flags: review?(dkl) → review?(mcote)
Comment 5•11 years ago
|
||
Comment on attachment 8532293 [details] [diff] [review]
Patch v.1
Review of attachment 8532293 [details] [diff] [review]:
-----------------------------------------------------------------
I'm not familiar with this setting, but this looks good. Couple nits:
::: docs/en/rst/administering/parameters.rst
@@ +222,5 @@
> leaving only the metadata.
>
> +xsendfile_header
> + By default, attachments are served by Bugzilla. If you enable filesystem
> + file storage for large files using the :param:`maxlocalattachment`
"filesystem file storage" is redundant; just "filesystem storage" works.
@@ +223,5 @@
>
> +xsendfile_header
> + By default, attachments are served by Bugzilla. If you enable filesystem
> + file storage for large files using the :param:`maxlocalattachment`
> + parameter then you can have those files served directly by the webserver,
Comma after "parameter" would add a bit of clarity to this sentence, although it might be worth breaking it into two sentences.
Attachment #8532293 -
Flags: review?(mcote) → review+
Assignee | ||
Updated•11 years ago
|
Flags: approval?
Assignee | ||
Comment 6•10 years ago
|
||
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
561465c..cd90214 master -> master
Gerv
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•