1107342 - Ctrl-Tab should prevent a few more thumbnails from expiring than are displayed in the UI

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Currently, when restarting Firefox and closing tabs, the Ctrl-Tab panel fills in the gaps with blank thumbnails.

Comment 1

[Jim Mathies [:jimm]]

Comment on attachment 8531790 [details] [diff] [review]
patch

Review of attachment 8531790 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-tabPreviews.js
@@ +514,1 @@
>        urls.push(this.tabList[i].linkedBrowser.currentURI.spec);

Can thumbnailCount be greater than the number of tabs here? It doesn't look like PageThumbs will catch an exception.

Comment 2

[Dão Gottwald [:dao]]

(In reply to Jim Mathies [:jimm] from comment #1)
> >        urls.push(this.tabList[i].linkedBrowser.currentURI.spec);
> 
> Can thumbnailCount be greater than the number of tabs here?

No, because of this.tabCount here:

+    const thumbnailCount = Math.min(this.tabPreviewCount + extraThumbnails,
+                                    this.tabCount);

Comment 3

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/db933e2f2077

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/db933e2f2077

Comment 5

[Cornel Ionce [:noni] [Hubs QA]]

Verified fixed on Windows 7 64-bit, Ubuntu 14.04 64-bit and Mac OS X 10.8.5 using Firefox 37 beta 6, build ID: 20150316202753.