If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Ctrl-Tab should prevent a few more thumbnails from expiring than are displayed in the UI

VERIFIED FIXED in Firefox 37

Status

()

Firefox
Tabbed Browser
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 37
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8531790 [details] [diff] [review]
patch

Currently, when restarting Firefox and closing tabs, the Ctrl-Tab panel fills in the gaps with blank thumbnails.
Attachment #8531790 - Flags: review?(ttaubert)
(Assignee)

Updated

3 years ago
Attachment #8531790 - Flags: review?(ttaubert) → review?(jmathies)

Comment 1

3 years ago
Comment on attachment 8531790 [details] [diff] [review]
patch

Review of attachment 8531790 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-tabPreviews.js
@@ +514,1 @@
>        urls.push(this.tabList[i].linkedBrowser.currentURI.spec);

Can thumbnailCount be greater than the number of tabs here? It doesn't look like PageThumbs will catch an exception.
(Assignee)

Comment 2

3 years ago
(In reply to Jim Mathies [:jimm] from comment #1)
> >        urls.push(this.tabList[i].linkedBrowser.currentURI.spec);
> 
> Can thumbnailCount be greater than the number of tabs here?

No, because of this.tabCount here:

+    const thumbnailCount = Math.min(this.tabPreviewCount + extraThumbnails,
+                                    this.tabCount);

Updated

3 years ago
Attachment #8531790 - Flags: review?(jmathies) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/db933e2f2077
https://hg.mozilla.org/mozilla-central/rev/db933e2f2077
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Verified fixed on Windows 7 64-bit, Ubuntu 14.04 64-bit and Mac OS X 10.8.5 using Firefox 37 beta 6, build ID: 20150316202753.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.