Closed Bug 1107368 Opened 6 years ago Closed 4 years ago

Tweak MediaPromise invariants to inhibit bad programming patterns

Categories

(Core :: Audio/Video: Playback, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: bholley, Unassigned)

References

Details

Attachments

(2 obsolete files)

We've discussed some tweaks which are worth implementing, but aren't worth blocking the landing of bug 1097823. Specifically:

* Having APIs return a non-addrefable temporary rather than an nsRefPtr<MediaPromise>
* Adding the option to assert exclusivity (i.e. that there should only be at most one Then() invocation per promise).
* Encouraging consumers to call SetMonitor (details TBD).
No longer depends on: 1097823
Depends on: 1108701
Depends on: 1123983
Comment on attachment 8552121 [details] [diff] [review]
Part 1 - Implement exclusivity checking for MediaPromises. v1

Wrong bug, sorry.
Attachment #8552121 - Attachment is obsolete: true
Attachment #8552121 - Flags: review?(cpearce)
Attachment #8552122 - Attachment is obsolete: true
Attachment #8552122 - Flags: review?(cpearce)
Component: Audio/Video → Audio/Video: Playback
Assignee: bobbyholley → nobody
Can we kick this bug out of media playback?
Flags: needinfo?(bobbyholley)
We have exclusivity checking now and the ship has probably sailed on return something non-addreffable. I think we can just WONTFIX it.
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(bobbyholley)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.