1107510 - Files downloaded in private browsing are not cleared with Clear now option

Status: RESOLVED DUPLICATE of bug 1114506

(Firefox for Android Graveyard :: Download Manager, defect)

Description

[Cristina Madaras, QA [:CristinaM]]

Environment:
Device: Nexus 4 (Android 4.4.4)
Build: Firefox for Android 37.0a1 (2014-12-04)

Steps to reproduce:
1. Launch Fennec and switch to private browsing;
2. Go to 1.usa.gov/deeXKM;
3. Go to about:downloads and observe the downloaded file on a dark background;
4. Go to Settings -> Privacy-> Clear now -> all boxes checked -> Clear data;
5. Go to about: downloads.

Actual results:
Files downloaded in private browsing are not cleared.

Expected results:
All downloaded files are cleared. Download manager is empty.

Notes: After browser restart, files downloaded in private browsing are not displayed anymore.

Comment 1

[Aaron Train [:aaronmt]]

Can you find a regression-range if this is indeed a regression? There's no indication in this bug report.

Comment 2

[u421692]

Can't tell how far back this is going, but Firefox 34 is affected and newer versions are affected.
Anyway, this is happening only if you open about:downloads in private browsing. After you close all private tabs, and open again about:downloads in private browsing, the download manager is empty.
I think it's actually the correct behavior, since saved data in private browsing is not preserved after you exit private browsing.

Comment 3

[Cristina Madaras, QA [:CristinaM]]

Not a regression, this is reproducible even on 2013 builds.
Mihai is right, after all private tabs are closed, download manager doesn't display files downloaded in private browsing anymore. This is happening also when Firefox is restarted.
But if you switch to normal browsing without closing the private tabs, in about:downloads will be displayed all downloaded files, in both normal and private browsing. While in normal browsing, clear private data via Settings -> Privacy-> Clear now -> all boxes checked -> Clear data, this should clear all downloaded files, no?

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Hi would like to know if I could take this bug and receive support for fixing it.

Comment 5

[Brian Nicholson (:bnicholson)]

Hi Francisco. Sure, and thanks! Sorry for the delay -- many of us have been on vacation for the holidays :)

The private data cleanup happens in Sanitizer.jsm at [1]. The downloads are removed from the list, then the files themselves are deleted at [2]. At first glance, nothing looks obviously wrong to me, so I'd suggest adding some logs to figure out if/why we're skipping private downloads here. Using dump() (which will write to logcat), I'd add a few logging lines to see if we're even iterating over private downloads in the first place, then go from there. The Download API is at [3], which could be useful for logging. Please don't hesitate to ask more questions if anything is unclear!

[1] http://mxr.mozilla.org/mozilla-central/source/mobile/android/modules/Sanitizer.jsm?rev=d6fb576da01d#184
[2] http://mxr.mozilla.org/mozilla-central/source/mobile/android/modules/Sanitizer.jsm?rev=d6fb576da01d#205
[3] https://developer.mozilla.org/en-US/docs/Mozilla/JavaScript_code_modules/Downloads.jsm/Download

Comment 6

[:Paolo Amadini]

Uh, this bug might well have been fixed by the migration to the JavaScript API for downloads in bug 1114506. The "Downloads.getList(Downloads.ALL)" call includes both public and private downloads.

Comment 7

[Brian Nicholson (:bnicholson)]

Hey, look at that! No wonder nothing looked wrong. Thanks, Paolo.

Francisco, looks like there's nothing to do here, but thanks for your interest in contributing! Here's a list of other unassigned mentored JS bugs if you'd like to take something else: http://www.joshmatthews.net/bugsahoy/?mobileandroid=1&js=1