Remove change to Chromium code to define _xgetbv for pre VS2010 SP1.

NEW
Unassigned

Status

()

4 years ago
4 years ago

People

(Reporter: bobowen, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
Once we drop support for VS2010 and Thunderbird and SeaMonkey build servers have moved to VS2013, we should remove the change made to the Chromium code in bug 1105729 to define our own version of _xgetbv.
(Reporter)

Updated

4 years ago
Summary: Remove change to Chromium code to define _xgetbv for pre VS2010. → Remove change to Chromium code to define _xgetbv for pre VS2010 SP1.

Comment 1

4 years ago
No win64 comm-central build is available after 25 Nov.
Is that build failure related with this bug?
(Reporter)

Comment 2

4 years ago
(In reply to Takanori MATSUURA from comment #1)
> No win64 comm-central build is available after 25 Nov.
> Is that build failure related with this bug?

No, this is about removing the fix for VS2010 x86, once we drop support for VS2010.
This is because it is a change to the imported Chromium code, which we don't want to keep any longer than we have to.

I thought that we were OK to wait until the builds moved to VS2013 for x64 support.
If we need a fix for Windows x64 VS2010 comm-central builds, please file a separate bug and assign it to me.
You need to log in before you can comment on or make changes to this bug.