Closed Bug 1107655 Opened 11 years ago Closed 11 years ago

ToS/Privacy need re-showing in 35 to avoid a large blank space

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Points:
1

Tracking

(firefox35 fixed, firefox36 fixed, firefox37 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla37
Iteration:
37.2
Tracking Flags:
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
firefox37 --- fixed
Blocking Flags:
backlog Fx35+

People

(Reporter: standard8, Assigned: rgauthier)

Details

Attachments

(2 files, 1 obsolete file)

Screen shot
66.12 KB, image/png
Details
Re-showing ToS in Fx35
5.25 KB, patch
NiKo
: review+
Sylvestre
: approval-mozilla-aurora+
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review
Attached image Screen shot —
Currently, when users get upgraded from 34 to 35, there will be a large blank space below the "Get Started" button. It seems most sensible that we should re-display the ToS/Privacy notice in 35 to avoid this.
Assignee: nobody → rgauthier
Priority: -- → P1
Attached patch Re-showing ToS in Fx35 (obsolete) — — Splinter Review
Attachment #8534365 - Flags: review?(standard8)
Comment on attachment 8534365 [details] [diff] [review] Re-showing ToS in Fx35 Review of attachment 8534365 [details] [diff] [review]: ----------------------------------------------------------------- This is fine, though could you also extend the tests in panel_test.js please.
Attachment #8534365 - Flags: review?(standard8) → review+
(In reply to Mark Banner (:standard8) (away until 15th Dec) from comment #2) > > This is fine, though could you also extend the tests in panel_test.js please. Romain -- Are you comfortable extending tests yourself?
Flags: needinfo?(rgauthier)
Attachment #8534365 - Attachment is obsolete: true
Flags: needinfo?(rgauthier)
Attachment #8535620 - Flags: review?(standard8)
Comment on attachment 8535620 [details] [diff] [review] Re-showing ToS in Fx35 Review of attachment 8535620 [details] [diff] [review]: ----------------------------------------------------------------- Niko -- If you have the bandwidth to review this, that would be great. Else it can wait until Mark gets back on Monday. Thanks!
Attachment #8535620 - Flags: review?(nperriault)
Comment on attachment 8535620 [details] [diff] [review] Re-showing ToS in Fx35 Review of attachment 8535620 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8535620 - Flags: review?(nperriault) → review+
Attachment #8535620 - Flags: review?(standard8)
https://hg.mozilla.org/integration/fx-team/rev/1d88918bd1f5
Iteration: --- → 37.2
Points: --- → 1
Target Milestone: --- → mozilla37
https://hg.mozilla.org/mozilla-central/rev/1d88918bd1f5
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
status-firefox35: --- → affected
status-firefox36: --- → affected
status-firefox37: --- → fixed
Flags: qe-verify-
Comment on attachment 8535620 [details] [diff] [review] Re-showing ToS in Fx35 Approval Request Comment [Feature/regressing bug #]: ROoms [User impact if declined]: UI ugliness [Describe test coverage new/current, TBPL]: on m-c, includes tests [Risks and why]: low risk - simple change [String/UUID change made/needed]: none
Attachment #8535620 - Flags: approval-mozilla-beta?
Attachment #8535620 - Flags: approval-mozilla-aurora?
Attachment #8535620 - Flags: approval-mozilla-beta?
Attachment #8535620 - Flags: approval-mozilla-beta+
Attachment #8535620 - Flags: approval-mozilla-aurora?
Attachment #8535620 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: