Closed Bug 1107658 Opened 5 years ago Closed 4 years ago
Undo fails after deleting node that has a pseudo element sibling
58 bytes, text/x-review-board-request
STR: Open https://bgrins.github.io/devtools-demos/inspector/pseudo.html Inspect one of the square nodes that has pseudo elements Delete one of the <p> element siblings Undo the change Expected: The <p> tag gets reinserted Actual Nothing happens - there is an error in the console: "Protocol error (unknownError): NotFoundError: Node was not found"
Inspector bug triage. Filter on CLIMBING SHOES. Still failing on FF45. This can be extremely painful for a user relying on undo/redo to test things -> P2.
Priority: -- → P2
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Check that the stored sibling is a valid target for insertBefore, update existing test to cover this use case. Review commit: https://reviewboard.mozilla.org/r/57326/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/57326/
Attachment #8759538 - Flags: review?(pbrosset)
Comment on attachment 8759538 [details] Bug 1107658 - fix undo for delete node when next sibling is a pseudo element; https://reviewboard.mozilla.org/r/57326/#review54324 Thanks, this looks good. I like how you managed to remove the setup function from the test array.
Attachment #8759538 - Flags: review?(pbrosset) → review+
Thanks for the review! Landing: https://hg.mozilla.org/integration/fx-team/rev/c8ca3bba2124
I have reproduced this bug with Nightly 37.0a1(2014-12-04) on Windows 10, 64 bit! The Bug's fix is now verified on latest Beta 49.0b2 Build ID 20160808002253 User Agent Mozilla/5.0 (Windows NT 10.0; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0 [bugday-20160810]
You need to log in before you can comment on or make changes to this bug.