Closed Bug 1107684 Opened 5 years ago Closed 5 years ago

ScriptSettings.cpp xpc::ErrorReport::Init() callers pass string where boolean is expected.

Categories

(Core :: XPConnect, defect)

36 Branch
x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: nsm, Assigned: nsm)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
No description provided.
Attachment #8532207 - Attachment is patch: true
Attachment #8532207 - Flags: review?(bobbyholley)
Comment on attachment 8532207 [details] [diff] [review]
patch

Review of attachment 8532207 [details] [diff] [review]:
-----------------------------------------------------------------

Yikes, good catch. This is a regression from bug 1070842, can could break devtools labeling. Let's get this uplifted.
Attachment #8532207 - Flags: review?(bobbyholley) → review+
Blocks: 1070842
Keywords: regression
Comment on attachment 8532207 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1070842
[User impact if declined]: Potentially mislabeled entries in devtools
[Describe test coverage new/current, TBPL]: None
[Risks and why]: Basically none - totally trivial. We passed a string where we were supposed to pass a boolean.
[String/UUID change made/needed]: None
Attachment #8532207 - Flags: approval-mozilla-beta?
Attachment #8532207 - Flags: approval-mozilla-aurora?
patch failed to apply cleanly:

patching file dom/base/ScriptSettings.cpp
Hunk #1 FAILED at 313
Hunk #2 FAILED at 470
2 out of 2 hunks FAILED -- saving rejects to file dom/base/ScriptSettings.cpp.rej

Could you take a look and also provide a try link? Thanks!
Flags: needinfo?(nsm.nikhil)
Keywords: checkin-needed
Attached patch patchSplinter Review
Not sure why it didn't apply, but this is a new one that applies to latest inbound as of writing. I am on a network that doesn't allow ssh, bholley, would you mind pushing to try? Thanks!
Attachment #8532207 - Attachment is obsolete: true
Attachment #8532207 - Flags: approval-mozilla-beta?
Attachment #8532207 - Flags: approval-mozilla-aurora?
Flags: needinfo?(nsm.nikhil)
Attachment #8533636 - Flags: review+
Comment on attachment 8533636 [details] [diff] [review]
patch

comment 2
Attachment #8533636 - Flags: approval-mozilla-beta?
Attachment #8533636 - Flags: approval-mozilla-aurora?
Assignee: nobody → nsm.nikhil
https://hg.mozilla.org/mozilla-central/rev/46b73f0a5e88
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Attachment #8533636 - Flags: approval-mozilla-beta?
Attachment #8533636 - Flags: approval-mozilla-beta+
Attachment #8533636 - Flags: approval-mozilla-aurora?
Attachment #8533636 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.