Closed
Bug 1107684
Opened 9 years ago
Closed 9 years ago
ScriptSettings.cpp xpc::ErrorReport::Init() callers pass string where boolean is expected.
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: nsm, Assigned: nsm)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
2.88 KB,
patch
|
nsm
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•9 years ago
|
Attachment #8532207 -
Attachment is patch: true
Attachment #8532207 -
Flags: review?(bobbyholley)
Comment 1•9 years ago
|
||
Comment on attachment 8532207 [details] [diff] [review] patch Review of attachment 8532207 [details] [diff] [review]: ----------------------------------------------------------------- Yikes, good catch. This is a regression from bug 1070842, can could break devtools labeling. Let's get this uplifted.
Attachment #8532207 -
Flags: review?(bobbyholley) → review+
Updated•9 years ago
|
Blocks: 1070842
Keywords: regression
Comment 2•9 years ago
|
||
Comment on attachment 8532207 [details] [diff] [review] patch Approval Request Comment [Feature/regressing bug #]: bug 1070842 [User impact if declined]: Potentially mislabeled entries in devtools [Describe test coverage new/current, TBPL]: None [Risks and why]: Basically none - totally trivial. We passed a string where we were supposed to pass a boolean. [String/UUID change made/needed]: None
Attachment #8532207 -
Flags: approval-mozilla-beta?
Attachment #8532207 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 3•9 years ago
|
||
patch failed to apply cleanly: patching file dom/base/ScriptSettings.cpp Hunk #1 FAILED at 313 Hunk #2 FAILED at 470 2 out of 2 hunks FAILED -- saving rejects to file dom/base/ScriptSettings.cpp.rej Could you take a look and also provide a try link? Thanks!
Flags: needinfo?(nsm.nikhil)
Keywords: checkin-needed
Updated•9 years ago
|
Assignee | ||
Comment 4•9 years ago
|
||
Not sure why it didn't apply, but this is a new one that applies to latest inbound as of writing. I am on a network that doesn't allow ssh, bholley, would you mind pushing to try? Thanks!
Attachment #8532207 -
Attachment is obsolete: true
Attachment #8532207 -
Flags: approval-mozilla-beta?
Attachment #8532207 -
Flags: approval-mozilla-aurora?
Flags: needinfo?(nsm.nikhil)
Attachment #8533636 -
Flags: review+
Assignee | ||
Comment 5•9 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=d4d2cd32e147
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8533636 [details] [diff] [review] patch comment 2
Attachment #8533636 -
Flags: approval-mozilla-beta?
Attachment #8533636 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Assignee: nobody → nsm.nikhil
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/46b73f0a5e88
Keywords: checkin-needed
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/46b73f0a5e88
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8533636 -
Flags: approval-mozilla-beta?
Attachment #8533636 -
Flags: approval-mozilla-beta+
Attachment #8533636 -
Flags: approval-mozilla-aurora?
Attachment #8533636 -
Flags: approval-mozilla-aurora+
Comment 9•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/98ed4b770b60 https://hg.mozilla.org/releases/mozilla-beta/rev/ed58170e9178
You need to log in
before you can comment on or make changes to this bug.
Description
•