1107743 - Set 'moderator' role when the room owner joins a room

Status: RESOLVED FIXED

(Hello (Loop) :: Server, defect, P1)

Description

[Mike de Boer [:mikedeboer]]

Right now the role is set to 'publisher' by default, so we can't forceDisconnect() the other connections when the owner deletes a room.

Comment 1

[Mike de Boer [:mikedeboer]]

Alexis, do you have enough information here to work on a solution?

Comment 2

[Alexis Metaireau (:alexis)]

I think I do, yes. This was next on my list, so I'm now on it :)

Comment 3

[Alexis Metaireau (:alexis)]

Ah, sorry, I was actually confusing this with bug 1107536 which should be out before that, so this will take some more time.

Comment 4

[Alexis Metaireau (:alexis)]

Okay, so as specified at https://wiki.mozilla.org/Loop/Architecture/Rooms#Removing_Participants_from_a_Room, 

> When the server generates a session participant token, it can also select a participant role. When creating a token for the room owner, the server must include a "role" of "moderator," which will allow the room owner to remove participants from rooms.
> 
> To remove a user from a room, the owner then uses the forceDisconnect method on the Sessionto remove a user from the room. Upon receiving a disconnection event for their own connection with a reason of "forceDisconnect," the removed client will remove himself from the session by calling POST /rooms/{token}. 

If I understand that properly, on the loop-server side, we just need to issue a token with a different role in the case we're creating the participant token of the room owner.

Comment 5

[Alexis Metaireau (:alexis)]

Attachment: Set 'moderator' role when the room owner joins a room

This should be the fix you want.

Comment 6

[Alexis Metaireau (:alexis)]

Comment on attachment 8533757 [details] [diff] [review]
Set 'moderator' role when the room owner joins a room

https://github.com/mozilla-services/loop-server/commit/0aed2e89fd92fb11e132343bb9d60a60e23a61ce

Comment 7

[Mike de Boer [:mikedeboer]]

I'd sure like to test this... is it on the dev server tomorrow? Thanks for fixing this!

Comment 8

[Alexis Metaireau (:alexis)]

Yes, I updated the dev-server to actually serve what's in 0.14.1.

Comment 10

[Mike de Boer [:mikedeboer]]

Comment on attachment 8533757 [details] [diff] [review]
Set 'moderator' role when the room owner joins a room

While working with the dev server, I've seen this working as expected. Thanks Alexis!