Closed
Bug 1107747
Opened 10 years ago
Closed 10 years ago
Create build for device branch 2.1s
Categories
(Release Engineering :: General, defect)
Tracking
(blocking-b2g:2.1S+, b2g-v2.1S fixed, b2g-v2.2 wontfix, b2g-master fixed)
RESOLVED
FIXED
blocking-b2g | 2.1S+ |
People
(Reporter: seinlin, Assigned: seinlin)
References
Details
Attachments
(8 files, 5 obsolete files)
14.54 KB,
patch
|
u429623
:
review+
rail
:
review+
|
Details | Diff | Splinter Review |
643 bytes,
patch
|
u429623
:
review+
|
Details | Diff | Splinter Review |
874 bytes,
patch
|
rail
:
review+
|
Details | Diff | Splinter Review |
4.60 KB,
patch
|
nthomas
:
review+
|
Details | Diff | Splinter Review |
18.75 KB,
patch
|
seinlin
:
review+
|
Details | Diff | Splinter Review |
18.24 KB,
patch
|
Details | Diff | Splinter Review | |
808 bytes,
patch
|
nthomas
:
review+
|
Details | Diff | Splinter Review |
503 bytes,
patch
|
catlee
:
review+
pmoore
:
checked-in+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Hal, Could you review this patch? Thanks!
Attachment #8532286 -
Flags: review?(hwine)
Assignee | ||
Comment 2•10 years ago
|
||
Hal, Could you review this patch? Thanks!
Attachment #8532288 -
Flags: review?(hwine)
Comment on attachment 8532286 [details] [diff] [review]
bug-1107747-part-1.patch
Review of attachment 8532286 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm
Attachment #8532286 -
Flags: review?(hwine) → review+
Comment on attachment 8532288 [details] [diff] [review]
bug-1107747-part-2.patch
Review of attachment 8532288 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm
Attachment #8532288 -
Flags: review?(hwine) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Running test-masters.sh is Passed.
Comment 6•10 years ago
|
||
Comment 7•10 years ago
|
||
In production: https://hg.mozilla.org/build/buildbotcustom/rev/c46bfda22efe
Comment on attachment 8532288 [details] [diff] [review]
bug-1107747-part-2.patch
http://hg.mozilla.org/build/buildbot-configs/rev/a15f53cafbd0
Attachment #8532288 -
Flags: checked-in+
Comment on attachment 8532288 [details] [diff] [review]
bug-1107747-part-2.patch
backed out due to bustage found by sheriffs. 's' missing on a number of device builds, disabling them on 2.1 instead
backout commit:
http://hg.mozilla.org/build/buildbot-configs/rev/2cc554bc3a33
Attachment #8532288 -
Flags: checked-in+ → checked-in-
Comment 10•10 years ago
|
||
Please fix the config, and re-attach for review. My apologies for missing this in PDX.
Flags: needinfo?(kli)
Comment 11•10 years ago
|
||
Assignee | ||
Comment 12•10 years ago
|
||
Hal, Thanks! We'll re-attach for review and land it after it is fixed.
Flags: needinfo?(kli)
Updated•10 years ago
|
blocking-b2g: --- → 2.1S+
Comment 13•10 years ago
|
||
Kai-Zhen, bug 1115297 is already fixed. Could you please help with this one?
Flags: needinfo?(kli)
Assignee | ||
Comment 14•10 years ago
|
||
Peipei, OK, I will do that. But the target device for v2.1s got some changes, so I need to finish bug 1120745. Keep NI for todo.
Depends on: 1120745
Assignee | ||
Comment 15•10 years ago
|
||
Hwine, Now branch 2.1s is ready. Could you review this patch? Thanks!
Assignee: nobody → kli
Attachment #8532288 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8548911 -
Flags: review?
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(kli)
Attachment #8548911 -
Flags: review? → review?(hwine)
Assignee | ||
Comment 16•10 years ago
|
||
Hwine, We need to add short name for dolphin, otherwise dolphin-512 will get error in test-masters.sh because of len > 30. Could you review this patch? Thanks!
Attachment #8548914 -
Flags: review?(hwine)
Assignee | ||
Comment 17•10 years ago
|
||
Comment on attachment 8532286 [details] [diff] [review]
bug-1107747-part-1.patch
This is already landed.
Attachment #8532286 -
Attachment is obsolete: true
Assignee | ||
Comment 18•10 years ago
|
||
Hwine, Could you review this patch? Thanks!
Attachment #8548917 -
Flags: review?(hwine)
Assignee | ||
Comment 19•10 years ago
|
||
Nick, We need to add a new device config. Could you review this patch? Thanks!
Attachment #8548924 -
Flags: review?(nthomas)
Assignee | ||
Comment 20•10 years ago
|
||
Assignee | ||
Comment 21•10 years ago
|
||
Nick, Could you review this patch? Thanks!
Comment 22•10 years ago
|
||
Comment on attachment 8548911 [details] [diff] [review]
bug-1107747-buildbot-configs.patch
Driveby comment ....
>diff --git a/mozilla/b2g_config.py b/mozilla/b2g_config.py
>+# dolphin-512 is for selected branches only
>+for branch in BRANCHES:
>+ if branch not in ('mozilla-b2g34_v2_1s'):
This needs to have a trailing comma in the tuple, ie
if branch not in ('mozilla-b2g34_v2_1s',):
Comment 23•10 years ago
|
||
Comment on attachment 8548924 [details] [diff] [review]
Add in-tree files for dolphin-512 on master.
Seems fine. I see you've not copied b2g/config/dolphin/releng-dolphin.tt over, could you comment on why that is ? (for anyone who comes an looks at this bug later).
Attachment #8548924 -
Flags: review?(nthomas) → review+
Comment 24•10 years ago
|
||
Comment on attachment 8548924 [details] [diff] [review]
Add in-tree files for dolphin-512 on master.
Actually, I don't think you need this patch, because the buildbot patch isn't adding dolphin-512 builders on master (aka mozilla-central), just 2.1s.
Comment 25•10 years ago
|
||
Comment on attachment 8548945 [details] [diff] [review]
bug-1107747-mozharness.patch
Review of attachment 8548945 [details] [diff] [review]:
-----------------------------------------------------------------
Could you clarify where dolphin-512 builds are going to run ? If it's only 2.1s then changes to master.py, v2.1.py and v2.2.py are unnecessary.
::: configs/b2g_bumper/v2.1s.py
@@ +7,5 @@
> + "gittool.py": ["/usr/local/bin/gittool.py"],
> + },
> + 'gecko_pull_url': 'https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/',
> + 'gecko_push_url': 'ssh://hg.mozilla.org/releases/mozilla-b2g34_v2_1/',
> + 'gecko_local_dir': 'mozilla-b2g34_v2_1',
Looks like you've done a copy of v2.1.py, and these three need updating.
@@ +11,5 @@
> + 'gecko_local_dir': 'mozilla-b2g34_v2_1',
> + 'git_ref_cache': '/builds/b2g_bumper/git_ref_cache.json',
> +
> + 'manifests_repo': 'https://git.mozilla.org/b2g/b2g-manifest.git',
> + 'manifests_revision': 'origin/v2.1',
And this.
@@ +19,5 @@
> + "ssh_user": "ffxbld",
> +
> + 'hgtool_base_bundle_urls': ['https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/bundles'],
> +
> + 'gaia_repo_url': 'https://hg.mozilla.org/integration/gaia-2_1',
And this, and I'll stop looking now but please check for others.
Attachment #8548945 -
Flags: review-
Assignee | ||
Comment 26•10 years ago
|
||
Hi Nick,
Yes, dolphin-512 will run on v2.1s only. I updated the patch, could you review it again when you have time?
Thanks!
Attachment #8548945 -
Attachment is obsolete: true
Attachment #8549303 -
Flags: review?(nthomas)
Assignee | ||
Comment 27•10 years ago
|
||
(In reply to Nick Thomas [:nthomas] from comment #23)
> Comment on attachment 8548924 [details] [diff] [review]
> Add in-tree files for dolphin-512 on master.
>
> Seems fine. I see you've not copied b2g/config/dolphin/releng-dolphin.tt
> over, could you comment on why that is ? (for anyone who comes an looks at
> this bug later).
To build dolphin and dolphin-512, we don't need the system backup tar file, because we can build all necessary binary from source.
Comment 28•10 years ago
|
||
Comment on attachment 8548914 [details] [diff] [review]
Add short name for dolphin.
Glad the tests caught this! :)
Attachment #8548914 -
Flags: review?(hwine) → review+
Comment 29•10 years ago
|
||
Comment on attachment 8548917 [details] [diff] [review]
Add dolphin-512 for buildbot.
Review of attachment 8548917 [details] [diff] [review]:
-----------------------------------------------------------------
I'm not familiar with the issues in adding a new device, :rail does.
Attachment #8548917 -
Flags: review?(hwine) → review?(rail)
Comment 30•10 years ago
|
||
Comment on attachment 8548911 [details] [diff] [review]
bug-1107747-buildbot-configs.patch
new branch looks right, deferring to :rail for new device changes.
Attachment #8548911 -
Flags: review?(rail)
Attachment #8548911 -
Flags: review?(hwine)
Attachment #8548911 -
Flags: review+
Updated•10 years ago
|
Attachment #8548917 -
Flags: review?(rail) → review+
Comment 31•10 years ago
|
||
Comment on attachment 8548911 [details] [diff] [review]
bug-1107747-buildbot-configs.patch
Review of attachment 8548911 [details] [diff] [review]:
-----------------------------------------------------------------
In overall it looks good, but i requires another patch to make it work. I get the following errors trying to run the tests:
ValueError: Cannot shorten "b2g_mozilla-b2g34_v2_1_dolphin-512_eng_dep" to maximum length (30). Got to: b2g_m-b34_21_dolphin-512_eng_dep
You need to add a rule to shorten "dolphin" in http://hg.mozilla.org/build/buildbotcustom/file/2b02c9c12a9c/common.py#l48
Assignee | ||
Comment 32•10 years ago
|
||
(In reply to Rail Aliiev [:rail] from comment #31)
> Comment on attachment 8548911 [details] [diff] [review]
> bug-1107747-buildbot-configs.patch
>
> Review of attachment 8548911 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> In overall it looks good, but i requires another patch to make it work. I
> get the following errors trying to run the tests:
>
> ValueError: Cannot shorten "b2g_mozilla-b2g34_v2_1_dolphin-512_eng_dep" to
> maximum length (30). Got to: b2g_m-b34_21_dolphin-512_eng_dep
>
> You need to add a rule to shorten "dolphin" in
> http://hg.mozilla.org/build/buildbotcustom/file/2b02c9c12a9c/common.py#l48
Rail, Thanks! I added a patch in comment 16 to fix it error. I think it should work.
Flags: needinfo?(rail)
Comment 33•10 years ago
|
||
Comment on attachment 8548911 [details] [diff] [review]
bug-1107747-buildbot-configs.patch
Oh, I missed that patch. With both applied it worked fine.
Thanks for your contribution and making our lives easier. :)
Flags: needinfo?(rail)
Attachment #8548911 -
Flags: review?(rail) → review+
Comment 34•10 years ago
|
||
(In reply to Kai-Zhen Li [:seinlin] from comment #27)
> To build dolphin and dolphin-512, we don't need the system backup tar file,
> because we can build all necessary binary from source.
OK. I was confused by http://hg.mozilla.org/mozilla-central/file/default/b2g/config/dolphin/releng-dolphin.tt but that was only recently added.
Comment 35•10 years ago
|
||
Comment on attachment 8549303 [details] [diff] [review]
bug-1107747-mozharness.patch
>diff --git a/configs/b2g_bumper/v2.1s.py b/configs/b2g_bumper/v2.1s.py
>+ 'gaia_repo_url': 'https://hg.mozilla.org/integration/gaia-2_1s',
This doesn't exist yet, please ask hwine/pmoore to set it up (if you haven't already). Otherwise looks fine.
Attachment #8549303 -
Flags: review?(nthomas) → review+
Assignee | ||
Comment 36•10 years ago
|
||
Correct DEVICE name for dolphin-512, carry r+.
Attachment #8548924 -
Attachment is obsolete: true
Attachment #8552202 -
Flags: review+
Assignee | ||
Comment 37•10 years ago
|
||
Attachment #8548925 -
Attachment is obsolete: true
Assignee | ||
Comment 38•10 years ago
|
||
https://hg.mozilla.org/build/braindump/rev/120ee7210327
https://hg.mozilla.org/build/buildbotcustom/rev/34e410cf73ca
https://hg.mozilla.org/build/buildbot-configs/rev/2232ba781e1e
https://hg.mozilla.org/build/mozharness/rev/fd342d8b4916
https://hg.mozilla.org/integration/b2g-inbound/rev/bf0e7704b8a4
https://hg.mozilla.org/releases/mozilla-b2g34_v2_1s/rev/4b542cf7b5eb
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Comment 40•10 years ago
|
||
buildbotcustom patch is in production
Comment 41•10 years ago
|
||
buildbot-config patch(es) are live in production
Comment 42•10 years ago
|
||
a mozharness patch has from this bug is in production
Assignee | ||
Comment 43•10 years ago
|
||
Nick, Could you review this patch for me? Thanks!
Attachment #8555000 -
Flags: review?(nthomas)
Comment 44•10 years ago
|
||
Comment on attachment 8555000 [details] [diff] [review]
bug-1107747-quick-fix.patch
Confirmed this drops these two builders:
< b2g_mozilla-b2g34_v2_1_dolphin-512_periodic ScriptFactory
< b2g_mozilla-b2g34_v2_1_dolphin-512_eng_periodic ScriptFactory
leaving 4 on 2.1 (opt+eng, periodic+nightly).
Attachment #8555000 -
Flags: review?(nthomas) → review+
Assignee | ||
Comment 45•10 years ago
|
||
Comment 46•10 years ago
|
||
Updated•10 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 47•10 years ago
|
||
This v2.1s config was invalid, and causing mozharness to fail.
We were also not alerted (see bug 1135030) - note this has not been working since it landed several days ago.
This error was only discovered as a side effect of investigating bug 1136148, which was unrelated (an hg process hanging).
Attachment #8568562 -
Flags: review?(catlee)
Updated•10 years ago
|
Attachment #8568562 -
Flags: review?(catlee) → review+
Comment 48•10 years ago
|
||
Comment on attachment 8568562 [details] [diff] [review]
bug1107747_mozharness_fix-b2g-bumper-config_v1.patch
Landed on default, jlund will merge later today during a reconfig.
https://hg.mozilla.org/build/mozharness/rev/21f00dd7bda6
Attachment #8568562 -
Flags: checked-in+
Comment 49•10 years ago
|
||
In production: https://hg.mozilla.org/build/mozharness/rev/21f00dd7bda6
Updated•10 years ago
|
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•