110781 - plugin scanning doesn't always catch duplicates

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Peter Lubczynski]

As we are now increasing the number of folders scanned for plugins, it is
becoming more important that plugin code correctly identify duplicate plugins
found during the scan. Currently, we use a static method called
areTheSameFileNames in nsPluginHostImpl.cpp that attempts to weed out duplicates
based on filename. 

I propse this be replaced by 3 checks:
1) compare nsPluginTag->mName  (same name, same plugin)
2) compare nsPluginTag->mDescription
3) compare nsPlugingTag->mMimeTypeArray (same handlers, same plugin)

The reason for those three checks is because filenames can change as with
symlinks and on Mac. Quicktime updates the mName field with it's versions so 5.0
and 5.02 won't match. However, Java and Flash use mDescription, so we check for
that next. Finally, there are some plugins that update neither of those fields
on update new versions, so we need to check the mime type array as well.

Comment 1

[Peter Lubczynski]

*** Bug 110778 has been marked as a duplicate of this bug. ***

Comment 2

[Peter Lubczynski]

Attachment: patch for deep compare

Comment 3

[av (gone)]

Comment on attachment 58377 [details] [diff] [review]
patch for deep compare

I like the patch, r=av

You may want o add a null-check, like

PRBool nsPluginTag::Equals(nsPluginTag *aPluginTag)
{
  if(!aPluginTag)
    return PR_FALSE;

Also, this code will not catch duplicates which are only different by the order
of the mime type listed, but I think this kind of situation is not likely.

Comment 4

[av (gone)]

Wcan we can also compare mLibrary on Unix, thus addressing bug 110768.

Comment 5

[Patrick C. Beard]

Comment on attachment 58377 [details] [diff] [review]
patch for deep compare

sr=beard

Comment 6

[Peter Lubczynski]

*** Bug 110768 has been marked as a duplicate of this bug. ***

Comment 7

[Peter Lubczynski]

Thanks!  I added a null pointer check/assertion but I think the mLibrary isn't
needed. Checking the order of mime types should be enough to catch duplicates.

Comment 8

[shrirang khanzode]

plugins get scanned fine now and are listed according to version numbers.