1107881 - Incorrect :path header field in HTTP/2 or SPDY proxy

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Tatsuhiro Tsujikawa]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.71 Safari/537.36

Steps to reproduce:

1. Setup HTTP/2 or SPDY proxy.  nghttpx+squid3 or node-spdyproxy will work.
2. Instruct Firefox to use HTTP/2 or SPDY proxy
3. Access the web site (plain http URL, not encrypted site)



Actual results:

Page correctly displays but in protocol level, :path pseudo header is incorrect.
It includes absolute URI like http://nghttp2.org/api.html


Expected results:

:path should be the path and query parts of the target URI, so when accessing http://nghttp2.org/api.html, :path should be /api.html, rather than full absolute URI.

From HTTP/2 draft-16 spec 8.1.2.3.  Request Pseudo-Header Fields:
"""
   o  The ":path" pseudo-header field includes the path and query parts
      of the target URI (the "path-absolute" production from [RFC3986]
      and optionally a '?' character followed by the "query" production,
      see [RFC3986], Section 3.3 and [RFC3986], Section 3.4).  A request
      in asterisk form includes the value '*' for the ":path" pseudo-
      header field.
"""

Chrome M39 sends correct :path in this case.

Comment 1

[Patrick McManus [:mcmanus]]

thanks - you're right.

The path is being derived from the h1 proxying rules which use an absolute uri in that situation

Comment 2

[Patrick McManus [:mcmanus]]

https://tbpl.mozilla.org/?tree=Try&rev=ca4bd3b5732a

Comment 3

[Patrick McManus [:mcmanus]]

Attachment: MozReview Request: bz://1107881/mcmanus

Comment 4

[Patrick McManus [:mcmanus]]

/r/1429 - bug 1107881 - h2/spdy :path when proxying shouldn't be abs uri r=hurley

Pull down this commit:

hg pull review -r d1ebc894bc6df75efa4b86bc20575d4afcc20a62

Comment 5

[u408661]

https://reviewboard.mozilla.org/r/1429/#review915

::: netwerk/protocol/http/nsHttpChannel.cpp
(Diff revision 1)
>      else {

nit: move the else up by the }

Comment 6

[u408661]

https://reviewboard.mozilla.org/r/1427/#review917

Ship It!

Comment 7

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0191461d0332

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0191461d0332

Comment 10

[Patrick McManus [:mcmanus]]

Attachment: MozReview Request: bug 1107881 - h2/spdy :path when proxying shouldn't be abs uri r=hurley