1107906 - Replace test runner use of devicemanagerADB.py with adb.py

Status: RESOLVED DUPLICATE of bug 1440714

(Testing :: General, defect)

Description

[Bob Clary [:bc] (inactive)]

While working on bug 1079923, I have found that using the --dm_trans=adb option on the mochitests/runtestsremote.py does not properly execute and retrieve the log files for the test run while using --dm_trans=sut does work.

There are a number of places in the test runner which there is a code branch for sut but none for adb. For example, 

http://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtestsremote.py#740

http://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtestsremote.py#750

I haven't discovered the exact missing adb support in the test runners yet, but thought since we have the need to fix adb support in the test runners, that we could take the opportunity to make the change to the adb.py, adb_android.py family in http://dxr.mozilla.org/mozilla-central/source/testing/mozbase/mozdevice/mozdevice/.

This would essentially result in devicemanagerADB being deprecated.

Thoughts?

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

I second this motion.

Comment 2

[Geoff Brown [:gbrown]]

I am not opposed, but note that I can run android mochitests via adb (make mochitest-remote) without incident.

Comment 3

[Bob Clary [:bc] (inactive)]

gbrown: that is interesting. I can actually kick off the tests on the phones and see them running, but I don't get the logs back from the device. I'll have to investigate that more.

Comment 4

[Geoff Brown [:gbrown]]

:bc -- This looks like ancient history now -- time to close?

Comment 5

[Bob Clary [:bc] (inactive)]

yep