Closed Bug 1107915 Opened 10 years ago Closed 10 years ago

Allow switching to Browser elements when in chrome

Categories

(Remote Protocol :: Marionette, defect)

Product:
Remote Protocol
Component:
Marionette
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla37

People

(Reporter: automatedtester, Assigned: automatedtester)

References

Details

(Keywords: pi-marionette-server, Whiteboard: [affects=loop])

Attachments

(2 files, 1 obsolete file)

MozReview Request: Bug 1107915: Allow switching to Browser elements from Marionette; r=mdas
39 bytes, text/x-review-board-request
mdas
: review+
Details
MozReview Request: remove items that shouldn't have been up for review
39 bytes, text/x-review-board-request
mdas
: review+
Details 
Currently Marionette only looks for XUL:Browser elements when switching but but we also have Browser elements as frames. This means that loop can't switch to their hello frame
Blocks: 1095303

        Attachment #8532539 -
        Flags: review?(mdas)

    
    

    
  
/r/1169 - Bug 1107915: Allow switching to Browser elements from Marionette; r=mdas
/r/1171 - remove items that shouldn't have been up for review

Pull down these commits:

hg pull review -r 6980775b909e30999cec0667b01e7243df2e733d

    
    

    
  
https://reviewboard.mozilla.org/r/1163/#review675

The second commit should cover some potential nits so check there too :)

    
    

    
  
Comment on attachment 8532539 [details]
MozReview Request: bz://1107915/AutomatedTester

r+ if it doesn't break Mn/Mnw

        Attachment #8532539 -
        Flags: review?(mdas) → review+

    
  
Assignee: nobody → dburns

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/16f8b6b0acff
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37

    
    

    
  
Thanks so much, guys; this fix is huge!

    
    

    
  

        Attachment #8532539 -
        Attachment is obsolete: true

        Attachment #8618814 -
        Flags: review+

        Attachment #8618815 -
        Flags: review+

    
  
Product: Testing → Remote Protocol

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: