1107918 - Remove ValueToIntegerRange in jsstr.cpp.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tooru Fujisawa [:arai]]

ValueToIntegerRange is not used anymore because String.prototype.substr/substring is now selfhosted (bug 1052839),
and now we can remove it.

Comment 1

[:ProgramFOX]

Attachment: Removed ValueToIntegerRange

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 8532564 [details] [diff] [review]
Removed ValueToIntegerRange

Thanks!

Comment 3

[:ProgramFOX]

Try push:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b51f1d654e25

Comment 4

[:ProgramFOX]

Try push succeeded. One of the JSReftests was busted, but it succeeded after a retrigger. Adding checkin-needed keyword.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2957dcebbfff

Comment 6

[Carsten Book [:Tomcat]]

sorry had to back this out for test failures like https://treeherder.mozilla.org/ui/logviewer.html#?job_id=4428091&repo=mozilla-inbound

Comment 7

[:ProgramFOX]

(In reply to Carsten Book [:Tomcat] from comment #6)
> sorry had to back this out for test failures like
> https://treeherder.mozilla.org/ui/logviewer.
> html#?job_id=4428091&repo=mozilla-inbound

Hmm... what does the warning mean exactly? I have been looking at the test file but could not see something that might be related to the removal of ValueToIntegerRange.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

The leak in that log wasn't yours. Relanded.
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b20423063f5

Comment 9

[:ProgramFOX]

Okay, thanks for letting me know!

Comment 10

[Tooru Fujisawa [:arai]]

Thank you all :)
It's already landed to m-c yesterday.
http://hg.mozilla.org/mozilla-central/rev/7b20423063f5

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7b20423063f5