Closed Bug 1107925 Opened 5 years ago Closed 5 years ago

Performing searches with Google search engine immediately launches Fennec

Categories

(Firefox for Android Graveyard :: Search Activity, defect)

ARM
Android
defect
Not set

Tracking

(firefox35 wontfix, firefox36 verified, firefox37 verified, fennec35+)

VERIFIED FIXED
Firefox 37
Tracking Status
firefox35 --- wontfix
firefox36 --- verified
firefox37 --- verified
fennec 35+ ---

People

(Reporter: cos_flaviu, Assigned: Margaret)

References

Details

Attachments

(1 file, 1 obsolete file)

Environment: 
Device: Samsung Galaxy Tab 2 (Android 4.0.4);
Build: Nightly 37.0a1 (2014-12-05);

Steps to reproduce:
1. Make sure the default search engine is Google;
2. Launch Search Activity;
3. Perform a search.

Expected result:
The results are displayed in Search Activity.

Actual result:
Fennec is launched and the search results are displayed in Fennec.
I'm not able to reproduce this. I set the default in-browser, and then launched the search activity. I typed 'firefox' and got results in the search activity as expected.

WFM.
Which locale are you using? What is the URL that appears in Fennec when the browser is launched?

This sounds like bug 1063193.
(In reply to :Margaret Leibovic from comment #2)
> Which locale are you using? What is the URL that appears in Fennec when the
> browser is launched?

The Firefox language is set to use system default.
The system default language is English-US, the time zone is set to US (GMT -6:00) and all the location services are unchecked.
All the search engines are searching on .com domain except Google. Google is searching on .ro (Romania).
Looks like Google gets the locale from the IP.
Maybe the only way to change it is to use proxy or vpn.
Is this still reproducible?
Flags: needinfo?(flaviu.cos)
(In reply to Aaron Train [:aaronmt] from comment #4)
> Is this still reproducible?
Yes, the bug is still reproducible.
Flags: needinfo?(flaviu.cos)
tracking-fennec: --- → ?
Assignee: nobody → margaret.leibovic
tracking-fennec: ? → 35+
Attachment #8546189 - Flags: review?(bnicholson)
/r/2225 - Bug 1107925 - Don't launch fennec on search redirects

Pull down this commit:

hg pull review -r 0e99b01c7b2d1fbd78e1dff646d9137684ed3af8
Attachment #8546189 - Flags: review?(bnicholson) → review+
I tested locally, but I'll request uplift after QA verifies this.

https://hg.mozilla.org/integration/fx-team/rev/bc1e8b764b5c
Keywords: verifyme
https://hg.mozilla.org/mozilla-central/rev/bc1e8b764b5c
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Verified as fixed in Firefox for Android 37.0a1 (2015-01-11)
Device: Asus Transformer Pad TF300T (Android 4.2.1)
Comment on attachment 8546189 [details]
MozReview Request: bz://1107925/margaret

Approval Request Comment
[Feature/regressing bug #]: search activity (on Fx35)
[User impact if declined]: for some search engines, search activity will launch Fennec instead of showing results in the search activity
[Describe test coverage new/current, TBPL]: landed on m-c, verified by QA
[Risks and why]: low-risk - small logic change that only affects search activity
[String/UUID change made/needed]: none

We're too late for 35 here, but we should uplift this to beta for 36.
Attachment #8546189 - Flags: approval-mozilla-beta?
Attachment #8546189 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed in Firefox for Android 36 Beta 2.
Devices:
Asus Transformer Pad TF300T (Android 4.2.1)
Asus Transformer Tab (Android 4.0.3)
Samsung Galaxy S4 (Android 4.4.2)
Status: RESOLVED → VERIFIED
Blocks: 1126700
Attachment #8546189 - Attachment is obsolete: true
Attachment #8618816 - Flags: review+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.