1107925 - Performing searches with Google search engine immediately launches Fennec

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[Flaviu Cos]

Environment: 
Device: Samsung Galaxy Tab 2 (Android 4.0.4);
Build: Nightly 37.0a1 (2014-12-05);

Steps to reproduce:
1. Make sure the default search engine is Google;
2. Launch Search Activity;
3. Perform a search.

Expected result:
The results are displayed in Search Activity.

Actual result:
Fennec is launched and the search results are displayed in Fennec.

Comment 1

[Aaron Train [:aaronmt]]

I'm not able to reproduce this. I set the default in-browser, and then launched the search activity. I typed 'firefox' and got results in the search activity as expected.

WFM.

Comment 2

[:Margaret Leibovic]

Which locale are you using? What is the URL that appears in Fennec when the browser is launched?

This sounds like bug 1063193.

Comment 3

[Flaviu Cos]

(In reply to :Margaret Leibovic from comment #2)
> Which locale are you using? What is the URL that appears in Fennec when the
> browser is launched?

The Firefox language is set to use system default.
The system default language is English-US, the time zone is set to US (GMT -6:00) and all the location services are unchecked.
All the search engines are searching on .com domain except Google. Google is searching on .ro (Romania).
Looks like Google gets the locale from the IP.
Maybe the only way to change it is to use proxy or vpn.

Comment 4

[Aaron Train [:aaronmt]]

Is this still reproducible?

Comment 5

[Flaviu Cos]

(In reply to Aaron Train [:aaronmt] from comment #4)
> Is this still reproducible?
Yes, the bug is still reproducible.

Comment 6

[:Margaret Leibovic]

Attachment: MozReview Request: bz://1107925/margaret

Comment 7

[:Margaret Leibovic]

/r/2225 - Bug 1107925 - Don't launch fennec on search redirects

Pull down this commit:

hg pull review -r 0e99b01c7b2d1fbd78e1dff646d9137684ed3af8

Comment 8

[Brian Nicholson (:bnicholson)]

https://reviewboard.mozilla.org/r/2225/#review1415

Comment 9

[Brian Nicholson (:bnicholson)]

https://reviewboard.mozilla.org/r/2223/#review1417

Comment 10

[:Margaret Leibovic]

I tested locally, but I'll request uplift after QA verifies this.

https://hg.mozilla.org/integration/fx-team/rev/bc1e8b764b5c

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bc1e8b764b5c

Comment 12

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in Firefox for Android 37.0a1 (2015-01-11)
Device: Asus Transformer Pad TF300T (Android 4.2.1)

Comment 13

[:Margaret Leibovic]

Comment on attachment 8546189 [details]
MozReview Request: bz://1107925/margaret

Approval Request Comment
[Feature/regressing bug #]: search activity (on Fx35)
[User impact if declined]: for some search engines, search activity will launch Fennec instead of showing results in the search activity
[Describe test coverage new/current, TBPL]: landed on m-c, verified by QA
[Risks and why]: low-risk - small logic change that only affects search activity
[String/UUID change made/needed]: none

We're too late for 35 here, but we should uplift this to beta for 36.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6796cf5b59b1

Comment 15

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in Firefox for Android 36 Beta 2.
Devices:
Asus Transformer Pad TF300T (Android 4.2.1)
Asus Transformer Tab (Android 4.0.3)
Samsung Galaxy S4 (Android 4.4.2)

Comment 17

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1107925 - Don't launch fennec on search redirects