Closed Bug 1107950 Opened 10 years ago Closed 10 years ago

[Stingray][System] homescreen app is shown as overlay on top of an alive app while press home.

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.2 S3 (9jan)

People

(Reporter: johnhu, Assigned: johnhu)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

We had landing app and homescreen app in bug 1074040. There is another requirement asking for showing homescreen app as an overlay on top of alive app.
Assignee: nobody → im
I will try to implement this in HomescreenWindowManager. But we still need to change some behaviors in WindowManager, like set visible, focus.
Hi all,

I had changed the behavior of AppWindowManager. The 'home' event handling is moved to HomescreenWindowManager. Please review this patch. Since this patch is critical, I would like to have two r+ to land it. Thanks.
Attachment #8538976 - Flags: review?(rexboy)
Attachment #8538976 - Flags: review?(lchang)
Whiteboard: [ft:conndevices]
Target Milestone: --- → 2.2 S3 (9jan)
Comment on attachment 8538976 [details] [review]
show home app as an overlay

See comments before landing.
Attachment #8538976 - Flags: review?(rexboy)
Attachment #8538976 - Flags: review+
Comment on attachment 8538976 [details] [review]
show home app as an overlay

Looks great!
Attachment #8538976 - Flags: review?(lchang) → review+
merged to master:
https://github.com/mozilla-b2g/gaia/commit/214c781be3c7b8fe44a627ede276e25c32cd828f
gaia-try is all green:
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=c0bbf4729fb3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
(In reply to John Hu [:johnhu][:johu][:醬糊小弟] from comment #2)
> Created attachment 8538976 [details] [review]
> show home app as an overlay
> 
> Hi all,
> 
> I had changed the behavior of AppWindowManager. The 'home' event handling is
> moved to HomescreenWindowManager. Please review this patch. Since this patch
> is critical, I would like to have two r+ to land it. Thanks.

Hi John

I want to confirm below story. 
1. AppsDeck
2. "Pin to Home" some app (with context menu)
3. Home is displayed and pinned app icon is displayed on home
4. "Home" key to undisplay home and landing app is launched

My expectation is only "Home" disappear and AppsDeck keeps alive(displayed).
So please consider how to hadle landing app and how to handle keys(hardware key events).

BR,
Daisuke



I still have some problem in my platform
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: