Closed
Bug 1107967
Opened 9 years ago
Closed 9 years ago
"Stop sharing" doesn't work on teared off tabs
Categories
(Firefox :: General, defect)
Tracking
()
People
(Reporter: florian, Assigned: florian)
References
Details
(Keywords: regression)
Attachments
(1 file)
11.14 KB,
patch
|
Felipe
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
From the investigation in bug 1098437, it turns out I regressed this in 35 with bug 973001. Impact of the bug: - the Stop sharing UI doesn't work - we are leaking the <browser> of the window were the tab lived before being teared off.
Flags: firefox-backlog+
Assignee | ||
Comment 1•9 years ago
|
||
[Tracking Requested - why for this release]: regression with possible privacy implications.
status-firefox35:
--- → affected
status-firefox36:
--- → affected
status-firefox37:
--- → affected
tracking-firefox35:
--- → ?
tracking-firefox36:
--- → ?
tracking-firefox37:
--- → ?
Assignee | ||
Comment 2•9 years ago
|
||
Turned out the "Stop sharing" action wasn't the only broken piece of the WebRTC UI after swapping tabs between windows. The "Allow" and "Deny" actions were also broken if a tab had been swapped with a pending gUM request.
Assignee | ||
Updated•9 years ago
|
Points: --- → 3
Flags: qe-verify+
Updated•9 years ago
|
Iteration: --- → 37.2
Comment 3•9 years ago
|
||
Comment on attachment 8533914 [details] [diff] [review] Fix Review of attachment 8533914 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/modules/webrtcUI.jsm @@ +73,5 @@ > + swapBrowserForNotification: function(aOldBrowser, aNewBrowser) { > + this._streams.forEach(stream => { > + if (stream.browser == aOldBrowser) > + stream.browser = aNewBrowser; > + }); for (let .. of ..) instead of closure?
Attachment #8533914 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/6e31e40ecf17
Whiteboard: [fixed-in-fx-team]
Updated•9 years ago
|
https://hg.mozilla.org/mozilla-central/rev/6e31e40ecf17
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8533914 [details] [diff] [review] Fix Approval Request Comment [Feature/regressing bug #]: bug 973001 [User impact if declined]: Impossible to stop sharing a camera/microphone in a detached tab. Serious privacy issue. [Describe test coverage new/current, TBPL]: Already on mozilla-central. [Risks and why]: acceptable, compared to the regression. [String/UUID change made/needed]: none.
Attachment #8533914 -
Flags: approval-mozilla-beta?
Attachment #8533914 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
QA Contact: paul.silaghi
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8533914 -
Flags: approval-mozilla-beta?
Attachment #8533914 -
Flags: approval-mozilla-beta+
Attachment #8533914 -
Flags: approval-mozilla-aurora?
Attachment #8533914 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 7•9 years ago
|
||
The patch here doesn't apply cleanly on mozilla-beta because bug 1095733 landed on 36 and isn't on 35.
Comment 8•9 years ago
|
||
(In reply to Florian Quèze [:florian] [:flo] from comment #7) > The patch here doesn't apply cleanly on mozilla-beta because bug 1095733 > landed on 36 and isn't on 35. Florian -- Does it make sense for me to ask for uplift on bug 1095733 to Fx35?
Flags: needinfo?(florian)
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/61340b38dced
Assignee | ||
Comment 10•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/8b4ca2960a3e
Assignee | ||
Comment 11•9 years ago
|
||
(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #8) > (In reply to Florian Quèze [:florian] [:flo] from comment #7) > > The patch here doesn't apply cleanly on mozilla-beta because bug 1095733 > > landed on 36 and isn't on 35. > > Florian -- Does it make sense for me to ask for uplift on bug 1095733 to > Fx35? I've unbitrotted my patch and landed it on beta anyway. For bug 1095733 that's up to you, but it doesn't seem to be a regression fix, so I wouldn't request uplift if it was my patch.
Flags: needinfo?(florian)
Comment 12•9 years ago
|
||
Verified fixed FF 36.0a2 (2014-12-15), 37.0a1 (2014-12-14) Win 7
Comment 13•9 years ago
|
||
Verified fixed FF 35b4 Win 7
Comment 14•9 years ago
|
||
I think this bug fix may have created this one: https://bugzilla.mozilla.org/show_bug.cgi?id=1122036 Any ideas on why isn't set notification.browser.messageManager on a Panel?
You need to log in
before you can comment on or make changes to this bug.
Description
•